From: Sam Ravnborg <sam@ravnborg.org>
To: Steven Whitehouse <swhiteho@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, cluster-devel@redhat.com,
Ingo Molnar <mingo@elte.hu>
Subject: Re: GFS2: Tracing support for review
Date: Wed, 15 Apr 2009 20:32:13 +0200 [thread overview]
Message-ID: <20090415183213.GA26155@uranus.ravnborg.org> (raw)
In-Reply-To: <1239810905.29604.60.camel@localhost.localdomain>
On Wed, Apr 15, 2009 at 04:55:05PM +0100, Steven Whitehouse wrote:
> Hi,
>
> This is my current patch to add tracepoints to GFS2. I couldn't use
> the recommended method of putting the trace_gfs2.h into fs/gfs2/
> because of something strange happening with the macros. The full
> path on my machine was: /home/steve/linux-2.6-tip/fs/gfs2 but
> somehow this was being substituted as: /home/steve/1-2.6-tip/fs/gfs2
> if I used the second method listed here: http://lkml.org/lkml/2009/4/14/578
Most likely because the preprocessor define the symbol "linux" to "1".
In general we should avoid playing games with include paths - it will
bite us.
Sam
prev parent reply other threads:[~2009-04-15 18:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-15 15:55 [Cluster-devel] GFS2: Tracing support for review Steven Whitehouse
2009-04-15 15:55 ` Steven Whitehouse
2009-04-15 16:12 ` Steven Rostedt
2009-04-15 17:45 ` Ingo Molnar
2009-04-16 10:18 ` [Cluster-devel] " Steven Whitehouse
2009-04-16 10:18 ` Steven Whitehouse
2009-04-24 16:26 ` [Cluster-devel] " Steven Whitehouse
2009-04-24 16:26 ` Steven Whitehouse
2009-04-15 18:32 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090415183213.GA26155@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=cluster-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.