All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Oren Laadan <orenl@cs.columbia.edu>
Cc: Dave Hansen <dave@linux.vnet.ibm.com>,
	xemul@parallels.com, containers@lists.linux-foundation.org,
	mingo@elte.hu, linux-kernel@vger.kernel.org, hch@infradead.org,
	akpm@linux-foundation.org, torvalds@linux-foundation.org,
	Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: CAP_SYS_ADMIN on restart(2)
Date: Wed, 15 Apr 2009 16:16:09 -0500	[thread overview]
Message-ID: <20090415211609.GA6704@us.ibm.com> (raw)
In-Reply-To: <49E64BFF.5080002@cs.columbia.edu>

Quoting Oren Laadan (orenl@cs.columbia.edu):
> 
> 
> Serge E. Hallyn wrote:
> > Quoting Dave Hansen (dave@linux.vnet.ibm.com):
> >> On Wed, 2009-04-15 at 23:21 +0400, Alexey Dobriyan wrote:
> >>> Is sysctl to control CAP_SYS_ADMIN on restart(2) OK?
> >> If the point is not to let users even *try* restarting things if it
> >> *might* not work, then I guess this might be reasonable.  
> >>
> >> If the goal is to increase security by always requiring CAP_SYS_ADMIN
> >> for "dangerous" operations, I fear it will be harmful.  We may have
> >> people adding features that are not considering the security impact of
> >> what they're doing just because the cases they care about all require
> >> privilege.
> > 
> > Nah, I disagree.  (Or put another way, that wouldn't be the goal)
> > There are two administrators we want to satisfy:
> > 
> > 1. the one who wants his users to do partial checkpoints, but doesn't
> > want to risk giving away any privilege at all in the process.  He'll
> > be satisified by setting restart(2) to not require cap_sys_admin,
> > and his users just won't be able to do a whole container.  A lot of
> > users will be happy with that (though no SYSVIPC support, then).
> 
> There is also a middle way: use setuid program to allow creation
> of a new namespace (under your favorite policy), then drop the
> privileges and continue as unprivileged inside that container.
> 
> IOW, don't make the initial container-creation a barrier for the
> entire operation.

That is still possible here.  But I don't think it's relevant.

What Alexey wants, I believe, is for users to be able to not have
to worry about there being exploitable bugs in restart(2) which
unprivileged users can play with.  And for the usual distro-kernel
reasons, saying use 'CONFIG_CHECKPOINT=n' is not an option.

-serge

  reply	other threads:[~2009-04-15 21:16 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-10  2:32 [PATCH 00/30] C/R OpenVZ/Virtuozzo style Alexey Dobriyan
     [not found] ` <20090410023207.GA27788-2ev+ksY9ol182hYKe6nXyg@public.gmane.org>
2009-04-10  2:44   ` Alexey Dobriyan
2009-04-10  5:07   ` Dave Hansen
2009-04-10  8:28   ` Ingo Molnar
2009-04-10  8:28     ` Ingo Molnar
     [not found]     ` <20090410082815.GA17962-X9Un+BFzKDI@public.gmane.org>
2009-04-10 11:45       ` Alexey Dobriyan
2009-04-10 11:45     ` Alexey Dobriyan
2009-04-10 15:06   ` Linus Torvalds
2009-04-14  5:46   ` Oren Laadan
2009-04-14  5:46     ` Oren Laadan
2009-04-14 15:19     ` Alexey Dobriyan
     [not found]     ` <49E4233C.3000108-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-04-14 15:19       ` Alexey Dobriyan
2009-04-10  2:44 ` Alexey Dobriyan
2009-04-10  5:07 ` Dave Hansen
2009-04-13  9:14   ` Alexey Dobriyan
2009-04-13  9:14   ` Alexey Dobriyan
2009-04-13 11:16     ` Dave Hansen
2009-04-14  4:26     ` Oren Laadan
     [not found]       ` <49E4108A.8050201-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-04-14 14:58         ` Alexey Dobriyan
2009-04-14 14:58       ` Alexey Dobriyan
     [not found]         ` <20090414145830.GA27461-2ev+ksY9ol182hYKe6nXyg@public.gmane.org>
2009-04-14 18:08           ` Oren Laadan
2009-04-14 18:08             ` Oren Laadan
2009-04-14 18:34             ` Alexey Dobriyan
     [not found]               ` <20090414183435.GA28233-2ev+ksY9ol182hYKe6nXyg@public.gmane.org>
2009-04-14 19:31                 ` Oren Laadan
2009-04-14 19:31               ` Oren Laadan
     [not found]                 ` <49E4E4AB.1030803-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-04-14 20:08                   ` Alexey Dobriyan
2009-04-14 20:08                     ` Alexey Dobriyan
     [not found]             ` <49E4D115.5080601-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-04-14 18:34               ` Alexey Dobriyan
2009-04-14 20:49               ` Alexey Dobriyan
2009-04-14 20:49             ` Alexey Dobriyan
2009-04-14 21:11               ` Dave Hansen
     [not found]               ` <20090414204912.GA28458-2ev+ksY9ol182hYKe6nXyg@public.gmane.org>
2009-04-14 21:11                 ` Dave Hansen
2009-04-14 21:39                 ` Serge E. Hallyn
2009-04-14 21:39               ` Serge E. Hallyn
     [not found]                 ` <20090414213934.GB17986-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-04-15 19:21                   ` CAP_SYS_ADMIN on restart(2) (was: Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style) Alexey Dobriyan
2009-04-15 19:21                 ` Alexey Dobriyan
2009-04-15 20:22                   ` Serge E. Hallyn
     [not found]                   ` <20090415192150.GC26994-2ev+ksY9ol182hYKe6nXyg@public.gmane.org>
2009-04-15 20:22                     ` Serge E. Hallyn
2009-04-15 20:23                     ` Dave Hansen
2009-04-15 20:23                   ` Dave Hansen
2009-04-15 20:39                     ` Serge E. Hallyn
2009-04-15 20:39                     ` Serge E. Hallyn
2009-04-15 21:05                       ` CAP_SYS_ADMIN on restart(2) Oren Laadan
2009-04-15 21:16                         ` Serge E. Hallyn [this message]
     [not found]                           ` <20090415211609.GA6704-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-04-16 15:35                             ` Alexey Dobriyan
2009-04-16 15:35                           ` Alexey Dobriyan
     [not found]                             ` <20090416153513.GA7876-2ev+ksY9ol182hYKe6nXyg@public.gmane.org>
2009-04-16 16:29                               ` Serge E. Hallyn
2009-04-16 16:29                             ` Serge E. Hallyn
     [not found]                         ` <49E64BFF.5080002-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-04-15 21:16                           ` Serge E. Hallyn
     [not found]                       ` <20090415203920.GA5475-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-04-15 21:05                         ` Oren Laadan
     [not found]     ` <20090413091423.GA19236-2ev+ksY9ol182hYKe6nXyg@public.gmane.org>
2009-04-13 11:16       ` [PATCH 00/30] C/R OpenVZ/Virtuozzo style Dave Hansen
2009-04-13 18:07       ` Dave Hansen
2009-04-13 18:07         ` Dave Hansen
2009-04-14  4:26       ` Oren Laadan
2009-04-10 15:06 ` Linus Torvalds
     [not found]   ` <alpine.LFD.2.00.0904100758410.4583-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-04-13  7:39     ` Alexey Dobriyan
2009-04-13  7:39   ` Alexey Dobriyan
     [not found]     ` <20090413073925.GB7085-2ev+ksY9ol182hYKe6nXyg@public.gmane.org>
2009-04-13 18:39       ` Linus Torvalds
2009-04-13 18:39         ` Linus Torvalds
2009-04-13 19:30         ` Ingo Molnar
     [not found]         ` <alpine.LFD.2.00.0904131137520.26713-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-04-13 19:30           ` Ingo Molnar
2009-04-14 12:29           ` Alexey Dobriyan
2009-04-14 12:29         ` Alexey Dobriyan
     [not found]           ` <20090414122906.GA20201-2ev+ksY9ol182hYKe6nXyg@public.gmane.org>
2009-04-14 13:44             ` Ingo Molnar
2009-04-14 17:09             ` Linus Torvalds
2009-04-14 13:44           ` Ingo Molnar
2009-04-14 16:53             ` Alexey Dobriyan
     [not found]             ` <20090414134420.GC27163-X9Un+BFzKDI@public.gmane.org>
2009-04-14 16:53               ` Alexey Dobriyan
2009-04-14 17:09           ` Linus Torvalds
     [not found]             ` <alpine.LFD.2.00.0904141006170.18124-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-04-14 17:19               ` Randy Dunlap
2009-04-14 17:19                 ` Randy Dunlap
     [not found]                 ` <49E4C5BD.1040405-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2009-04-14 17:32                   ` Linus Torvalds
2009-04-14 17:32                     ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090415211609.GA6704@us.ibm.com \
    --to=serue@us.ibm.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=dave@linux.vnet.ibm.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=orenl@cs.columbia.edu \
    --cc=torvalds@linux-foundation.org \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.