All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: kay.sievers@vrfy.org
Cc: greg@kroah.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: sparc: struct device - replace bus_id with dev_name(), dev_set_name()
Date: Thu, 16 Apr 2009 15:56:43 -0700 (PDT)	[thread overview]
Message-ID: <20090416.155643.06066521.davem@davemloft.net> (raw)
In-Reply-To: <1239898912.17211.7.camel@poy>

From: Kay Sievers <kay.sievers@vrfy.org>
Date: Thu, 16 Apr 2009 18:21:52 +0200

> On Fri, 2009-03-27 at 17:27 -0700, David Miller wrote:
>> From: Kay Sievers <kay.sievers@vrfy.org>
>> Date: Fri, 27 Mar 2009 13:21:56 +0100
>> 
>> > it took a while, but it happened now, so this issue is coming back. :)
>> > 
>> > The name size limit is gone, there is no BUS_ID_SIZE thing anymore in
>> > the driver core. BUS_ID_SIZE should go away in the 2.6.30 timeframe.
>> > 
>> > Could you please convert/remove BUS_ID_SIZE value from:
>> >   drivers/net/gianfar.h:	char	phy_bus_id[BUS_ID_SIZE];
>> >   drivers/net/ucc_geth.h:	char phy_bus_id[BUS_ID_SIZE];
>> >   drivers/net/pasemi_mac.h:	char	phy_id[BUS_ID_SIZE];
>> >   include/linux/phy.h:#define MII_BUS_ID_SIZE	(BUS_ID_SIZE - 3)
>> >   include/linux/phy.h:	char bus_id[BUS_ID_SIZE];
>> > 
>> > Or let me know how you want to convert it, so I can do it?
>> 
>> Thanks a lot Kay, I'll look into these cases and take care
>> of it.
> 
> This moves the 20 into the netdevice header, we need to get rid
> of the driver core define now, otherwise people start adding new
> code using it, and we want to finish this thankless job finally. :)

I was working on fixing this properly Kay, please be patient.

I'll have it killed off in net-next-2.6 soon enough.

  reply	other threads:[~2009-04-16 22:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-07  0:43 sparc: struct device - replace bus_id with dev_name(), dev_set_name() Kay Sievers
2008-11-07  7:35 ` David Miller
2008-11-07  8:33   ` Kay Sievers
2008-11-07  9:38     ` David Miller
2008-11-07  9:58       ` Kay Sievers
2008-11-07 19:36         ` David Miller
2009-03-27 12:21       ` Kay Sievers
2009-03-28  0:27         ` David Miller
2009-04-16 16:21           ` Kay Sievers
2009-04-16 22:56             ` David Miller [this message]
2009-05-22 11:42               ` Kay Sievers
2009-05-22 11:42                 ` Kay Sievers
2009-05-26  9:30                 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090416.155643.06066521.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=greg@kroah.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.