From: Al Viro <viro@ZenIV.linux.org.uk>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: H Hartley Sweeten <hartleys@visionengravers.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block/genhd.c: fix sparse warning
Date: Thu, 16 Apr 2009 06:42:05 +0100 [thread overview]
Message-ID: <20090416054205.GX26366@ZenIV.linux.org.uk> (raw)
In-Reply-To: <19f34abd0904152146l3db9961bt3b52f224abc8d960@mail.gmail.com>
On Thu, Apr 16, 2009 at 06:46:32AM +0200, Vegard Nossum wrote:
> 2009/4/16 H Hartley Sweeten <hartleys@visionengravers.com>:
> > Fix sparse warning in block/genhd.c.
> >
> > ?? ?? ?? ??warning: symbol '__mptr' shadows an earlier one
> >
> > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>
> Hi,
>
> Just a heads up: There seems to be some sort of consensus that this
> type of patch title is not a very good one. (What about "remove
> variable shadowing"?)
Indeed. Speaking of other kind of unpleasantness, could you please
configure your mail-luser-agent to *NOT* replace tabs with series
of spaces/nbsp? That crap is very annoying - these strings of
U+00A0 U+00A0 U+00A0 et sodding cetera are gratuitously making life
painful for non-UTF8 terminals.
next prev parent reply other threads:[~2009-04-16 5:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 1:53 [PATCH] block/genhd.c: fix sparse warning H Hartley Sweeten
2009-04-16 4:46 ` Vegard Nossum
2009-04-16 5:42 ` Al Viro [this message]
2009-04-16 7:17 ` Vegard Nossum
2009-04-16 18:03 ` H Hartley Sweeten
2009-04-16 18:33 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090416054205.GX26366@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.