All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: Remove duplicated code for Sequoia NAND booting version
Date: Thu, 16 Apr 2009 07:30:12 +0200	[thread overview]
Message-ID: <200904160730.13172.sr@denx.de> (raw)
In-Reply-To: <20090416051306.2266A83420E8@gemini.denx.de>

On Thursday 16 April 2009, Wolfgang Denk wrote:
> > So what the patch does is to remove an unused code part. Is this what you
> > are complaining about? If really needed I could resend this patch with a
> > modified patch subject.
>
> No, I complain that you also change a vital costant without even
> mentioning.

The constant was not used at all (as I mentioned in my last mail). So changing 
it to the really used value seems logical to me.

> Normally, this should be split into two separate patches., but at
> least it should be stated in the commit message.

I'll resend the patch with a changed commit text later.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

      reply	other threads:[~2009-04-16  5:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-15  9:33 [U-Boot] [PATCH] ppc4xx: Remove duplicated code for Sequoia NAND booting version Stefan Roese
2009-04-15 21:53 ` Wolfgang Denk
2009-04-16  4:51   ` Stefan Roese
2009-04-16  5:13     ` Wolfgang Denk
2009-04-16  5:30       ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200904160730.13172.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.