From: Alex Sidorenko <alexandre.sidorenko@hp.com>
To: David Miller <davem@davemloft.net>
Cc: "jarkao2@gmail.com" <jarkao2@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: An inconsistency/bug in ingress netem timestamps
Date: Thu, 16 Apr 2009 08:09:56 -0400 [thread overview]
Message-ID: <200904160809.56228.alexandre.sidorenko@hp.com> (raw)
In-Reply-To: <20090416.031034.41207844.davem@davemloft.net>
On April 16, 2009 06:10:34 am David Miller wrote:
> Since IFB completely bypasses netif_rx() and netif_receive_skb() I
> think it should unconditionally set skb->tstamp.tv64 to zero and
> invoke net_timestamp()
>From ifb.c (2.6.29):
109 if (from & AT_EGRESS) {
110 dp->st_rx_frm_egr++;
111 dev_queue_xmit(skb);
112 } else if (from & AT_INGRESS) {
113 dp->st_rx_frm_ing++;
114 skb_pull(skb, skb->dev->hard_header_len);
115 netif_rx(skb);
116 }
Adding skb->tstamp.tv64 = 0 between lines 114 and 115 made 'ping' report the
delay as expected (tested on 2.6.28)
Alex
--
------------------------------------------------------------------
Alexandre Sidorenko email: asid@hp.com
WTEC Linux Hewlett-Packard (Canada)
------------------------------------------------------------------
next prev parent reply other threads:[~2009-04-16 12:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-13 19:50 An inconsistency/bug in ingress netem timestamps Alex Sidorenko
2009-04-15 19:50 ` Jarek Poplawski
2009-04-15 20:10 ` Alex Sidorenko
2009-04-15 20:26 ` Jarek Poplawski
2009-04-15 20:29 ` Stephen Hemminger
2009-04-15 21:00 ` Alex Sidorenko
2009-04-15 23:41 ` David Miller
2009-04-16 10:10 ` David Miller
2009-04-16 12:09 ` Alex Sidorenko [this message]
2009-04-16 21:48 ` Jarek Poplawski
2009-04-17 12:04 ` David Miller
2009-04-17 16:50 ` Alex Sidorenko
2009-04-17 20:08 ` [PATCH] " Jarek Poplawski
2009-04-20 9:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904160809.56228.alexandre.sidorenko@hp.com \
--to=alexandre.sidorenko@hp.com \
--cc=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.