From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754025AbZDPJJn (ORCPT ); Thu, 16 Apr 2009 05:09:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752509AbZDPJJe (ORCPT ); Thu, 16 Apr 2009 05:09:34 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:44007 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752292AbZDPJJd (ORCPT ); Thu, 16 Apr 2009 05:09:33 -0400 Date: Thu, 16 Apr 2009 11:08:26 +0200 From: Ingo Molnar To: Yinghai Lu Cc: Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , Suresh Siddha , "Eric W. Biederman" , Rusty Russell , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 3/8] irq: make set_affinity to return status -v2 Message-ID: <20090416090826.GG9813@elte.hu> References: <49E68C41.4020801@kernel.org> <49E68CBC.8090507@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49E68CBC.8090507@kernel.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Yinghai Lu wrote: > Impact: prepare to use it to keep affinity consistent > > according to Ingo, change set_affinity() in irq_chip to return int. > > v2: fix two typo > > Signed-off-by: Yinghai Lu > > --- > arch/alpha/kernel/sys_dp264.c | 8 +++- > arch/alpha/kernel/sys_titan.c | 4 +- > arch/arm/common/gic.c | 4 +- > arch/cris/arch-v32/kernel/irq.c | 4 +- > arch/ia64/hp/sim/hpsim_irq.c | 3 + > arch/ia64/kernel/iosapic.c | 10 +++-- > arch/ia64/kernel/msi_ia64.c | 16 +++++--- > arch/ia64/sn/kernel/irq.c | 4 +- > arch/ia64/sn/kernel/msi_sn.c | 8 ++-- > arch/mips/cavium-octeon/octeon-irq.c | 8 +++- > arch/mips/include/asm/irq.h | 2 - > arch/mips/kernel/irq-gic.c | 5 +- > arch/mips/mti-malta/malta-smtc.c | 4 +- > arch/mips/sibyte/bcm1480/irq.c | 8 ++-- > arch/mips/sibyte/sb1250/irq.c | 8 ++-- > arch/parisc/kernel/irq.c | 6 ++- > arch/powerpc/platforms/pseries/xics.c | 12 +++--- > arch/powerpc/sysdev/mpic.c | 4 +- > arch/sparc/kernel/irq_64.c | 12 ++++-- > arch/x86/kernel/apic/io_apic.c | 64 +++++++++++++++++++++------------- > drivers/parisc/iosapic.c | 6 ++- > drivers/xen/events.c | 12 +++--- > include/linux/irq.h | 2 - > 23 files changed, 140 insertions(+), 74 deletions(-) Yeah, this patch looks _much_ nicer than the open-coded cpumask-copy lines. It makes it really apparent which architectures can fail the affinity setting and which not. This is proper layered design - the previous patch was open-coding implementation details into the affinity-setting handlers and was thus obfuscating the code and was making it harder to maintain. There is one omission: this should be Cc:-ed to linux-arch@vger.kernel.org, because it affects all architectures. Ingo