From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: akpm@linux-foundation.org, containers@lists.linux-foundation.org,
xemul@parallels.com, dave@linux.vnet.ibm.com, mingo@elte.hu,
orenl@cs.columbia.edu, hch@infradead.org,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 19/30] cr: deal with nsproxy
Date: Thu, 16 Apr 2009 15:55:03 -0500 [thread overview]
Message-ID: <20090416205503.GA28928@us.ibm.com> (raw)
In-Reply-To: <20090410023809.GT27788@x200.localdomain>
Quoting Alexey Dobriyan (adobriyan@gmail.com):
> To save nsproxy, or to not save nsproxy?
>
> Don't think much, save it.
>
> I argue that nsproxy should be removed totally, if someone thinks otherwise. ;-)
You've got Oren starting to agree with you too. I personally don't
much care in principle, and your code looks very nice.
The way you do this and the uts patch, though, you (of course) bypass
the CAP_SYS_ADMIN check in copy_namespaces(). Which is fine for your
patchset, but a problem if we were to base a compromise patchset on
your patchset.
It of course also enforces the 'leakage' checks, which again is
subject to our whole-container c/r discussion.
But again, the code is nice, and I see no problems in it.
-serge
next prev parent reply other threads:[~2009-04-16 20:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-10 2:38 [PATCH 19/30] cr: deal with nsproxy Alexey Dobriyan
2009-04-16 20:55 ` Serge E. Hallyn [this message]
[not found] ` <20090416205503.GA28928-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-04-16 21:03 ` Oren Laadan
2009-04-16 21:03 ` Oren Laadan
[not found] ` <20090410023809.GT27788-2ev+ksY9ol182hYKe6nXyg@public.gmane.org>
2009-04-16 20:55 ` Serge E. Hallyn
-- strict thread matches above, loose matches on Subject: below --
2009-04-10 2:38 Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090416205503.GA28928@us.ibm.com \
--to=serue@us.ibm.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=orenl@cs.columbia.edu \
--cc=torvalds@linux-foundation.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.