From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH] tracing: add #include <linux/delay.h> to fix build failure in test_work()
Date: Fri, 17 Apr 2009 02:30:42 +0200 [thread overview]
Message-ID: <20090417003042.GD29630@elte.hu> (raw)
In-Reply-To: <alpine.DEB.2.00.0904161008080.6495@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
>
>
> On Thu, 16 Apr 2009, Ingo Molnar wrote:
> >
> > ------------------------>
> > >From 63c14122a54c26122ccdbe596123f8e2b75c3116 Mon Sep 17 00:00:00 2001
> > From: Ingo Molnar <mingo@elte.hu>
> > Date: Thu, 16 Apr 2009 10:26:51 +0200
> > Subject: [PATCH] tracing: add #include <linux/delay.h> to fix build failure in test_work()
> > MIME-Version: 1.0
> > Content-Type: text/plain; charset=utf-8
> > Content-Transfer-Encoding: 8bit
> >
> > This build failure occured on a few rare configs:
> >
> > kernel/trace/trace_events.c: In function ?test_work?:
> > kernel/trace/trace_events.c:975: error: implicit declaration of function ?udelay?
> > kernel/trace/trace_events.c:980: error: implicit declaration of function ?msleep?
> >
> > delay.h is included in way too many other headers, hiding cases
> > where new usage is added without header inclusion.
> >
> > Impact: build fix
> > Signed-off-by: Ingo Molnar <mingo@elte.hu>
>
> Thanks Ingo!
>
> I don't see this change in tip, do you want me to apply it in my tree?
It's pushed out now.
Ingo
next prev parent reply other threads:[~2009-04-17 0:31 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 2:18 [PATCH 0/5] [GIT PULL] updates for tip Steven Rostedt
2009-04-16 2:18 ` [PATCH 1/5] ftrace: use module notifier for function tracer Steven Rostedt
2009-04-16 15:36 ` Frederic Weisbecker
2009-04-16 15:53 ` Steven Rostedt
2009-04-17 11:44 ` Steven Rostedt
2009-04-19 11:25 ` Rusty Russell
2009-04-20 13:57 ` Steven Rostedt
2009-04-21 5:15 ` Rusty Russell
2009-04-21 13:13 ` Steven Rostedt
2009-04-21 13:58 ` Ingo Molnar
2009-04-21 17:51 ` Tim Abbott
2009-04-21 18:17 ` Steven Rostedt
2009-04-21 18:47 ` Tim Abbott
2009-04-22 9:16 ` Ingo Molnar
2009-04-22 22:20 ` Tim Abbott
2009-04-22 22:57 ` Masami Hiramatsu
2009-04-23 19:40 ` Anders Kaseorg
2009-04-23 19:57 ` Mathieu Desnoyers
2009-04-23 22:31 ` Tim Abbott
2009-04-24 3:11 ` Masami Hiramatsu
2009-04-23 20:06 ` Masami Hiramatsu
2009-04-16 2:18 ` [PATCH 2/5] tracing/events: add startup tests for events Steven Rostedt
2009-04-16 8:39 ` [PATCH] tracing: add #include <linux/delay.h> to fix build failure in test_work() Ingo Molnar
2009-04-16 14:08 ` Steven Rostedt
2009-04-17 0:30 ` Ingo Molnar [this message]
2009-04-16 15:41 ` [PATCH 2/5] tracing/events: add startup tests for events Frederic Weisbecker
2009-04-16 15:51 ` Steven Rostedt
2009-04-16 16:02 ` Frederic Weisbecker
2009-04-16 2:18 ` [PATCH 3/5] tracing/events: add rcu locking around trace event prints Steven Rostedt
2009-04-17 14:08 ` Steven Rostedt
2009-04-17 15:20 ` Jeremy Fitzhardinge
2009-04-17 15:42 ` Steven Rostedt
2009-04-17 23:53 ` Jeremy Fitzhardinge
2009-04-17 16:18 ` Theodore Tso
2009-04-17 16:32 ` Jeremy Fitzhardinge
2009-04-17 16:41 ` Steven Rostedt
2009-05-07 2:10 ` Steven Rostedt
2009-05-07 11:32 ` Ingo Molnar
2009-05-07 13:10 ` Steven Rostedt
2009-04-16 2:18 ` [PATCH 4/5] tracing/events/ring-buffer: expose format of ring buffer headers to users Steven Rostedt
2009-04-16 2:18 ` [PATCH 5/5] tracing: add saved_cmdlines file to show cached task comms Steven Rostedt
2009-04-16 15:54 ` Frederic Weisbecker
2009-04-16 15:58 ` Steven Rostedt
2009-04-16 16:05 ` Frederic Weisbecker
2009-04-16 9:51 ` [PATCH 0/5] [GIT PULL] updates for tip Ingo Molnar
2009-04-16 9:53 ` Ingo Molnar
2009-04-16 13:52 ` Steven Rostedt
2009-04-16 16:12 ` Ingo Molnar
2009-04-16 16:22 ` Steven Rostedt
2009-04-17 0:29 ` Ingo Molnar
2009-04-16 16:30 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090417003042.GD29630@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.