From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH] c/r: Take uts_sem during checkpoint (v2) Date: Fri, 17 Apr 2009 10:17:21 -0500 Message-ID: <20090417151721.GB20466@us.ibm.com> References: <1239978438-5719-1-git-send-email-danms@us.ibm.com> <20090417150529.GB19129@us.ibm.com> <87ab6fiabr.fsf@caffeine.danplanet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <87ab6fiabr.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Dan Smith Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org List-Id: containers.vger.kernel.org Quoting Dan Smith (danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org): > SH> So it would be robust to future code changes if you > > SH> #define MAX_UTS_LEN (__NEW_UTS_LEN+1) > > SH> in utsname.h, so that anyone expanding the size of hostname > SH> doesn't need to look for this usage. > > Yeah, I think that came up in a prior round of comments on the UTS > stuff, but got dropped when we started depending on strlen() of the > names instead. I suppose I should actually do it now... :) Ok, please keep my Ack on the result. thanks, -serge