From: Al Viro <viro@ZenIV.linux.org.uk>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
takata@linux-m32r.org, Christoph Hellwig <hch@lst.de>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: use include/gen for mach-types.h
Date: Sat, 18 Apr 2009 19:52:26 +0100 [thread overview]
Message-ID: <20090418185226.GS26366@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20090418181714.GA25786@uranus.ravnborg.org>
On Sat, Apr 18, 2009 at 08:17:14PM +0200, Sam Ravnborg wrote:
> mach-types.h is a generated file.
> As we no longer has a .gitignore file in asm-arm the risk
> that somebody by accident commit mach-types.h is big.
>
> Avoid this by the introduction of include/gen/ to
> hold this (and soon other) generated files.
>
> The patch includes two small cleanups to arch/arm/Makefile.
> 1) delete stale comment
> 2) combine two targets in one line and drop unused prerequisite
>
> The idea to introduce include/gen/ is originally from Al Viro.
Umm...
a) why CLEAN_FILES and not MRPROPER_FILES?
b) I'd simply add include/gen to MRPROPER_FILES in the top-level
Makefile.
c) .gitignore in there ought to be simply *, if we want to create
.gitignore there at all (we don't do that for include/config and the
world doesn't end, after all).
next prev parent reply other threads:[~2009-04-18 18:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 15:07 last remaining asm/ header moves: h8300 and m32r Christoph Hellwig
2009-04-16 16:40 ` Sam Ravnborg
2009-04-17 2:23 ` [GIT PULL] m32r: move include/asm-m32r to arch/m32r/include/asm takata
2009-04-17 17:37 ` Linus Torvalds
2009-04-17 22:14 ` Sam Ravnborg
2009-04-18 10:14 ` Russell King
2009-04-18 18:17 ` [PATCH] arm: use include/gen for mach-types.h Sam Ravnborg
2009-04-18 18:52 ` Al Viro [this message]
2009-04-18 19:28 ` Linus Torvalds
2009-04-18 19:55 ` [PATCH v2] " Sam Ravnborg
2009-04-18 20:53 ` [PATCH] " Al Viro
2009-04-16 16:49 ` last remaining asm/ header moves: h8300 and m32r Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090418185226.GS26366@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=sam@ravnborg.org \
--cc=takata@linux-m32r.org \
--cc=torvalds@linux-foundation.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.