From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Ben Dooks <ben-linux-arm@fluff.org>,
linux-arm-kernel@lists.arm.linux.org.uk,
linux-input@vger.kernel.org
Subject: Re: [PATCH 3/5] [ARM] pxa: lx: add keyboard driver
Date: Mon, 20 Apr 2009 02:04:12 -0700 [thread overview]
Message-ID: <200904200204.12612.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20090420082513.GC21187@n2100.arm.linux.org.uk>
On Monday 20 April 2009 01:25:13 Russell King - ARM Linux wrote:
> On Sat, Apr 18, 2009 at 04:10:28PM -0700, Dmitry Torokhov wrote:
> > Hi Russell,
> >
> > On Sat, Apr 18, 2009 at 03:20:50PM +0100, Russell King wrote:
> > > +static int __init lx_keyb_init(void)
> > > +{
> > > + printk(KERN_INFO "LX Keyboard Driver, (c) 2004 Simtec
> > > Electronics\n");
> >
> > Is this needed? Input core will already add printk when input device is
> > added and our boot is already chatty enough...
>
> Simtec themselves would need to remove that line.
Umm, why? We not removing copyright notice from the file, just the
message...
--
Dmitry
next prev parent reply other threads:[~2009-04-20 9:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-18 14:19 [PATCH 0/5] PXA LX platform support Russell King - ARM Linux
[not found] ` <20090418141932.GA1236-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2009-04-18 14:20 ` [PATCH 1/5] [ARM] pxa: lx: add PCON i2c driver Russell King
[not found] ` <1240064452-14691-1-git-send-email-linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
2009-04-18 14:29 ` Jean Delvare
[not found] ` <20090418162900.0dc16531-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-04-18 14:42 ` Russell King - ARM Linux
[not found] ` <20090418144234.GB1236-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2009-04-18 17:34 ` Mark Brown
2009-04-18 18:10 ` Russell King - ARM Linux
[not found] ` <20090418181030.GC1236-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2009-04-19 11:11 ` Mark Brown
[not found] ` <20090419111114.GA8569-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2009-04-20 12:18 ` Russell King - ARM Linux
[not found] ` <20090420121805.GE3653-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2009-04-20 12:25 ` Mark Brown
2009-04-18 14:20 ` [PATCH 3/5] [ARM] pxa: lx: add keyboard driver Russell King
2009-04-18 23:10 ` Dmitry Torokhov
2009-04-20 8:25 ` Russell King - ARM Linux
2009-04-20 9:04 ` Dmitry Torokhov [this message]
2009-04-20 10:56 ` Russell King - ARM Linux
2009-04-20 11:06 ` Russell King - ARM Linux
2009-04-20 11:13 ` [PATCH 3/5 UPDATED] " Russell King - ARM Linux
2009-04-21 2:16 ` Dmitry Torokhov
2009-04-22 18:56 ` Russell King - ARM Linux
2009-04-21 2:15 ` [PATCH 3/5] " Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904200204.12612.dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=ben-linux-arm@fluff.org \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-input@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.