From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] fix mmap2 syscall
Date: Mon, 20 Apr 2009 22:14:40 +0000 [thread overview]
Message-ID: <20090420221440.GA31719@linux-sh.org> (raw)
In-Reply-To: <4.2.0.58.J.20090421052216.0362b680@router.itonet.co.jp>
On Tue, Apr 21, 2009 at 06:48:43AM +0900, SUGIOKA Toshinobu wrote:
> Last argument of mmap2 system call is always (offset >> 12) in glibc
> regardless of the PAGE_SIZE, but do_mmap_pgoff function requires
> 'pgoff' parameter which is shifted by real PAGE_SHIFT. So, we should
> adjust this argument if page size is not equal to 4k byte.
>
Good catch, I added a sanity check and a comment. It will be in the
2.6.30 queue, thanks!
prev parent reply other threads:[~2009-04-20 22:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 21:48 [PATCH] fix mmap2 syscall SUGIOKA Toshinobu
2009-04-20 22:14 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090420221440.GA31719@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.