From: Al Viro <viro@ZenIV.linux.org.uk>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
hooanon05@yahoo.co.jp, hch@infradead.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v2] Fix i_mutex handling in nfsd readdir
Date: Tue, 21 Apr 2009 01:29:34 +0100 [thread overview]
Message-ID: <20090421002934.GB8633@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20090420195008.GE1823@fieldses.org>
> Sorry for the delay. Simpler might be just to drop and reacquire the
> mutex each time through nfsd4_list_rec_dir()'s loop, but I'd just as
> soon rework the called functions to expect the mutex be held (and get
> rid of the unused, probably fragile, clear_clid_dir() in the process).
>
> So the following could be folded in to your patch.
>
> I tested the combined patch over 2.6.30-rc2. I also tested 2.6.29 +
> 05f4f678 + the combined patch. Both look OK. Feel free to add a
> tested-by or acked-by for "J. Bruce Fields" <bfields@citi.umich.edu> as
> appropriate. Or happy to add a s-o-b and shepherd it along myself if
> it's easier....
I can take both, but if you prefer to have that one go through nfs tree -
fine by me.
I'm going to push a queue into for-next in a couple of hours; running build
tests right now. Patch from dwmw2 is in there...
next prev parent reply other threads:[~2009-04-21 0:29 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-19 14:54 Q: NFSD readdir in linux-2.6.28 hooanon05
2009-03-19 15:17 ` David Woodhouse
2009-03-19 15:34 ` hooanon05
2009-03-19 15:51 ` David Woodhouse
2009-04-17 9:32 ` David Woodhouse
2009-04-17 19:32 ` Al Viro
2009-04-17 22:17 ` David Woodhouse
2009-04-17 22:43 ` Al Viro
2009-04-17 22:51 ` David Woodhouse
2009-04-17 22:53 ` Al Viro
2009-04-17 22:55 ` David Woodhouse
2009-04-17 23:23 ` David Woodhouse
2009-04-17 23:37 ` Al Viro
2009-04-17 23:39 ` Al Viro
2009-04-18 0:15 ` [PATCH] Fix i_mutex handling in nfsd readdir David Woodhouse
2009-04-18 3:11 ` hooanon05
2009-04-18 14:25 ` Al Viro
2009-04-19 7:18 ` David Woodhouse
2009-04-19 12:27 ` [PATCH v2] " David Woodhouse
2009-04-19 20:51 ` J. Bruce Fields
2009-04-20 19:50 ` J. Bruce Fields
2009-04-21 0:29 ` Al Viro [this message]
2009-04-21 21:15 ` J. Bruce Fields
2009-04-21 21:54 ` Al Viro
2009-05-11 23:16 ` J. Bruce Fields
2009-04-22 4:41 ` hooanon05
2009-04-22 19:12 ` J. Bruce Fields
2009-04-23 6:40 ` hooanon05
2009-04-23 20:27 ` J. Bruce Fields
2009-05-05 23:35 ` J. Bruce Fields
2009-05-06 5:09 ` hooanon05
2009-05-06 20:20 ` J. Bruce Fields
2009-05-07 4:38 ` hooanon05
2009-05-08 18:47 ` J. Bruce Fields
2009-03-19 15:37 ` Q: NFSD readdir in linux-2.6.28 Matthew Wilcox
2009-03-19 15:45 ` hooanon05
2009-03-19 16:01 ` David Woodhouse
2009-04-16 21:45 ` J. Bruce Fields
2009-04-17 4:13 ` hooanon05
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090421002934.GB8633@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=bfields@fieldses.org \
--cc=dwmw2@infradead.org \
--cc=hch@infradead.org \
--cc=hooanon05@yahoo.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.