From: Johan Herland <johan@herland.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] Minor cleanup and bugfixing in git-notes.sh
Date: Tue, 21 Apr 2009 02:51:34 +0200 [thread overview]
Message-ID: <200904210251.34945.johan@herland.net> (raw)
In-Reply-To: <alpine.DEB.1.00.0904210248560.10279@pacific.mpi-cbg.de>
On Tuesday 21 April 2009, Johannes Schindelin wrote:
> On Tue, 21 Apr 2009, Johan Herland wrote:
> > The following changes are made:
> > - Rename $MESSAGE to $MSG_FILE which better describes its purpose
> > - Make sure not only $MSG_FILE is removed upopn completion, but also
> > $GIT_INDEX_FILE
> > - Remove stray "GIT_NOTES_REF=" in front of "git log ..." command
>
> Valid points. Mind if I squash this into the commit adding git-notes.sh?
No problem
Have fun! :)
...Johan
--
Johan Herland, <johan@herland.net>
www.herland.net
next prev parent reply other threads:[~2009-04-21 0:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-21 0:39 [PATCH 0/2] Add "-m" and "-F" options to "git notes edit" Johan Herland
2009-04-21 0:41 ` [PATCH 1/2] Minor cleanup and bugfixing in git-notes.sh Johan Herland
2009-04-21 0:49 ` Johannes Schindelin
2009-04-21 0:51 ` Johan Herland [this message]
2009-04-21 0:42 ` [PATCH 2/2] Teach "-m <msg>" and "-F <file>" to "git notes edit" Johan Herland
2009-04-21 0:53 ` Johannes Schindelin
2009-04-21 1:26 ` [PATCH v2 " Johan Herland
2009-04-21 0:48 ` [PATCH 0/2] Add "-m" and "-F" options " Johannes Schindelin
-- strict thread matches above, loose matches on Subject: below --
2009-05-15 0:12 [PATCH 1/2] Minor cleanup and bugfixing in git-notes.sh Johan Herland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904210251.34945.johan@herland.net \
--to=johan@herland.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.