From: Evgeniy Polyakov <zbr@ioremap.net>
To: Johann Baudy <johann.baudy@gnu-log.net>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Patrick McHardy <kaber@trash.net>, jamal <hadi@cyberus.ca>
Subject: Re: [PATCH] TX_RING and packet mmap
Date: Tue, 21 Apr 2009 13:41:49 +0400 [thread overview]
Message-ID: <20090421094149.GA22907@ioremap.net> (raw)
In-Reply-To: <7e0dd21a0904181438j251f4f8cnc210c6dee8ce5212@mail.gmail.com>
Hi Johann.
On Sat, Apr 18, 2009 at 11:38:48PM +0200, Johann Baudy (johann.baudy@gnu-log.net) wrote:
> > I think it should only be called when shared area is about to be freed
> > and not when attached skb is freed.
> During skb_linearize(). shared info is memcopied and freed in
> pskb_expand_head() if not enough memory is available in current head.
> Then, Do you expect this new destructor to be called twice? (during
> skb_linearize() and kfree_skb())
It cals skb_release_data() which should invoke shared area destructor
before being freed.
> >Thus you can put your pages into
> > fraglist and reuse them after the last reference to the shared area is
> > gone.
>
> If my understanding is correct, skb can be linearized without calling
> skb_release_data() (if enough space is available in head). Hence, In
> this case, I will not have access to original frags[] from
> skb_shared_info destructor.
Yes, that's right.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2009-04-21 9:41 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-02 19:48 [PATCH] TX_RING and packet mmap Johann Baudy
2009-04-07 7:26 ` Herbert Xu
2009-04-07 12:48 ` jamal
2009-04-07 13:04 ` Herbert Xu
2009-04-07 13:47 ` jamal
2009-04-07 14:17 ` Herbert Xu
2009-04-07 14:40 ` Johann Baudy
[not found] ` <7e0dd21a0904070738jd8a2714wd840352699f1e9f1@mail.gmail.com>
2009-04-07 20:56 ` jamal
2009-04-07 21:11 ` Evgeniy Polyakov
2009-04-08 21:06 ` Johann Baudy
2009-04-12 10:27 ` Johann Baudy
2009-04-12 10:32 ` Evgeniy Polyakov
2009-04-12 11:23 ` Johann Baudy
2009-04-12 14:24 ` Evgeniy Polyakov
2009-04-12 19:27 ` Johann Baudy
2009-04-12 19:52 ` Evgeniy Polyakov
2009-04-12 20:30 ` Johann Baudy
2009-04-12 20:53 ` Evgeniy Polyakov
2009-04-12 23:31 ` Johann Baudy
2009-04-15 7:10 ` Evgeniy Polyakov
2009-04-15 13:14 ` Johann Baudy
2009-04-16 11:16 ` Evgeniy Polyakov
2009-04-18 21:38 ` Johann Baudy
2009-04-21 9:41 ` Evgeniy Polyakov [this message]
2009-04-21 13:16 ` Johann Baudy
2009-04-21 13:56 ` Evgeniy Polyakov
2009-04-08 6:51 ` Herbert Xu
2009-04-21 15:36 ` Christoph Lameter
2009-04-21 20:13 ` Johann Baudy
2009-04-21 20:42 ` Christoph Lameter
2009-04-21 21:00 ` Johann Baudy
2009-04-21 21:00 ` Christoph Lameter
2009-04-21 21:13 ` Johann Baudy
2009-04-21 20:46 ` Johann Baudy
2009-04-21 20:43 ` Christoph Lameter
2009-04-21 21:05 ` Johann Baudy
2009-04-21 21:08 ` Christoph Lameter
-- strict thread matches above, loose matches on Subject: below --
2009-04-26 13:06 Johann Baudy
2009-04-29 9:18 ` Evgeniy Polyakov
2009-04-30 20:17 ` Johann Baudy
2009-05-05 21:38 Johann Baudy
2009-05-06 7:07 ` Jarek Poplawski
2009-05-06 9:38 ` Jarek Poplawski
2009-05-09 20:31 ` David Miller
2009-05-11 21:21 Johann Baudy
2009-05-12 16:11 ` Andi Kleen
[not found] ` <7e0dd21a0905121058m1f894de6q9805e5392aef3aea@mail.gmail.com>
2009-05-12 18:00 ` Johann Baudy
[not found] ` <7e0dd21a0905121058m1f894de6q9805e5392aef3aea-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-12 18:15 ` Andi Kleen
2009-05-19 5:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090421094149.GA22907@ioremap.net \
--to=zbr@ioremap.net \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=johann.baudy@gnu-log.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.