All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-arch@vger.kernel.org
Subject: Re: introduce arch/$ARCH/Kbuild ?
Date: Tue, 21 Apr 2009 15:14:30 +0200	[thread overview]
Message-ID: <20090421131430.GA25098@linux-mips.org> (raw)
In-Reply-To: <20090416183701.GA5810@uranus.ravnborg.org>

On Thu, Apr 16, 2009 at 08:37:01PM +0200, Sam Ravnborg wrote:

> We have discussed privately the possiblity to cover
> all of arch/x86/* with -Werror and I came up with some
> suggestions so we could cover all subdirectories
> with a simple:
> 
>     subdir-ccflags-y := -Werror
> 
> I will sent a separate post on this when I have a patch ready..
> 
> But doing so required us to modify a lot of Makefiles
> in arch/x86 - too much for my taste.
> 
> Looking futher I realised that we could move all the core-y
> stuff to a separate Kbuild file as done by the appended patch.
> We would then cover all the directories with a single:
> 
>     subdir-ccflags-y := -Werror
> 
> 
> This has the added benefit that you can now do:
> 
>     make arch/x86/
> 
> And you will build most (but not all) of the x86 files.
> That alone was enough rationale for Ingo to apply it (and I agree).
> 
> What remains are the libs-y and driver-y parts.
> There is no way to specify these today.
> 
> If you think this looks wortwhile for your architecture I
> will be glad to help cook up a patch - albeit it is trivial
> to do so yourself.

Most of arch/mips uses -Werror these days and while painful at times it
keeps everybody on their toes hopefully cleaner, less buggy code.  So if
your solution allows adding -Werror to all subdirs automatically with
a mechanism to remove -Werror from a few selected dirs then I'm interested.

  Ralf

  reply	other threads:[~2009-04-21 15:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-16 18:37 introduce arch/$ARCH/Kbuild ? Sam Ravnborg
2009-04-21 13:14 ` Ralf Baechle [this message]
2009-04-21 19:43   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090421131430.GA25098@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.