From: Jamie Lokier <jamie@shareable.org>
To: Riku Voipio <riku.voipio@iki.fi>
Cc: laurent.desnogues@gmail.com, qemu-devel@nongnu.org,
Arnaud Patard <arnaud.patard@rtp-net.org>
Subject: Re: [Qemu-devel] [PATCH] Fix utimensat (aka unbreak cp -a)
Date: Tue, 21 Apr 2009 15:42:14 +0100 [thread overview]
Message-ID: <20090421144214.GC6375@shareable.org> (raw)
In-Reply-To: <20090421123455.GA15170@kos.to>
Riku Voipio wrote:
> Soo.. glibc uses utimensat to implement futimens, but doesn't allow
> applications to use utimensat in the same way. What a mess.
It protects against apps passing in NULL path due to a bug and
touching the directory by accident. A minor bit of protection indeed.
> But if we are to go towards using libc calls, your patch is a step
> backwards. In case pathname is null, we can use futimens.
I agree, good idea.
-- Jamie
next prev parent reply other threads:[~2009-04-21 14:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-21 8:24 [Qemu-devel] [PATCH] Fix utimensat (aka unbreak cp -a) Arnaud Patard
2009-04-21 8:36 ` Laurent Desnogues
2009-04-21 12:34 ` Riku Voipio
2009-04-21 14:42 ` Jamie Lokier [this message]
2009-04-21 16:09 ` Martin Mohring
2009-04-21 16:38 ` Martin Mohring
2009-04-21 18:18 ` Riku Voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090421144214.GC6375@shareable.org \
--to=jamie@shareable.org \
--cc=arnaud.patard@rtp-net.org \
--cc=laurent.desnogues@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.