From: Jens Axboe <jens.axboe@oracle.com>
To: Radha Ramachandran <radha@google.com>
Cc: fio@vger.kernel.org
Subject: Re: Issue running random reads with verify on a raw device
Date: Wed, 22 Apr 2009 08:21:32 +0200 [thread overview]
Message-ID: <20090422062132.GV4593@kernel.dk> (raw)
In-Reply-To: <20090422060528.GU4593@kernel.dk>
On Wed, Apr 22 2009, Jens Axboe wrote:
> On Tue, Apr 21 2009, Radha Ramachandran wrote:
> > Hi Jens,
> > Ah right, I missed the offset.
> > My interpretation of the options was that the check needs to be that
> > the (new random block + offset) needs to be < both the real_file_size
> > and io_size.
> >
> > Iam not sure i understand what you said very well, so the fix that I have is:
>
> I read up on the code, and I think your previous patch was correct. The
> offset isn't added until later in the process, so we should indeed not
> check the offset in this location.
>
> I'll test your previous patch and add it, sorry for the noise!
Everything appears to be in working order, I have added your fix.
Thanks!
--
Jens Axboe
next prev parent reply other threads:[~2009-04-22 6:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-10 22:57 Issue running random reads with verify on a raw device Radha Ramachandran
2009-04-18 17:53 ` Jens Axboe
2009-04-21 23:31 ` Radha Ramachandran
2009-04-22 6:05 ` Jens Axboe
2009-04-22 6:21 ` Jens Axboe [this message]
2009-04-22 6:22 ` Radha Ramachandran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090422062132.GV4593@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=fio@vger.kernel.org \
--cc=radha@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.