All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Lindahl <greg@blekko.com>
To: David Miller <davem@davemloft.net>
Cc: penguin-kernel@i-love.sakura.ne.jp, paul.moore@hp.com,
	linux-security-module@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] LSM: Add security_socket_post_accept() and security_socket_post_recv_datagram().
Date: Tue, 21 Apr 2009 23:54:43 -0700	[thread overview]
Message-ID: <20090422065443.GC4221@bx9.net> (raw)
In-Reply-To: <20090421.234618.181879214.davem@davemloft.net>

On Tue, Apr 21, 2009 at 11:46:18PM -0700, David Miller wrote:

> EAGAIN does not happen if the application calls poll(), gets
> an indication that connections are available, and then
> immediately calls accept() on the indicated FD.

I have observed it recently and historically, and not by calling
accept() repeatedly. I don't know what you mean by "immediately" since I
don't think you're advocating race conditions; the other end can
always exit/reset/whatever between the poll() and the accept().

> If overly anal apps "code for it" that is entirely besides the point.
> What we have to be concerned for, from a kernel behavioral standpoint,
> is that some apps "might not code for it".  This is why we don't
> change behavior.

I am suggesting that you survey actual apps. If you find that they're
all overly anal, then maybe you've learned something about EAGAIN
already happening today. I assure you that the co-worker who stuck in
the "ignore EAGAIN without logging it" only did so because he saw it
fairly frequently. He's that way.

-- greg



  reply	other threads:[~2009-04-22  6:54 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-14 10:44 [PATCH] LSM: Add security_socket_post_accept() and security_socket_post_recv_datagram() Tetsuo Handa
2009-04-14 22:59 ` Paul Moore
2009-04-15  5:12   ` Tetsuo Handa
2009-04-15 10:51     ` [PATCH 1/2] " Tetsuo Handa
2009-04-15 10:51     ` [PATCH 2/2] tomoyo: Add network access control support Tetsuo Handa
2009-04-16 18:23     ` [PATCH] LSM: Add security_socket_post_accept() and security_socket_post_recv_datagram() Paul Moore
2009-04-18  8:34       ` Tetsuo Handa
2009-04-20 22:22         ` Paul Moore
2009-04-21 10:54           ` Tetsuo Handa
2009-04-21 10:57             ` David Miller
2009-04-21 11:39               ` Tetsuo Handa
2009-04-21 11:40                 ` David Miller
2009-04-21 12:26                   ` Tetsuo Handa
2009-04-21 12:37                     ` David Miller
2009-04-21 12:52                       ` [PATCH] LSM: Add security_socket_post_accept() andsecurity_socket_post_recv_datagram() Tetsuo Handa
2009-04-21 13:04                         ` David Miller
2009-04-22  0:55                           ` [PATCH] LSM: Add security_socket_post_accept() and security_socket_post_recv_datagram() Tetsuo Handa
2009-04-22  1:14                             ` David Miller
2009-04-22  1:49                               ` Tetsuo Handa
2009-04-22  4:22                                 ` David Miller
2009-04-22  5:02                                   ` Tetsuo Handa
2009-04-22  5:07                                     ` David Miller
2009-04-22  5:38                                       ` Tetsuo Handa
2009-04-22  5:52                                         ` David Miller
2009-04-23 14:00                                           ` Tetsuo Handa
2009-04-23 14:10                                             ` David Miller
2009-04-23 14:47                                             ` Samir Bellabes
2009-04-22  1:52                               ` Greg Lindahl
2009-04-22  4:23                                 ` David Miller
2009-04-22  6:10                                   ` Greg Lindahl
2009-04-22  6:34                                     ` David Miller
2009-04-22  6:41                                       ` Greg Lindahl
2009-04-22  6:46                                         ` David Miller
2009-04-22  6:54                                           ` Greg Lindahl [this message]
2009-04-22  6:58                                             ` David Miller
2009-04-22  7:19                                           ` Tetsuo Handa
2009-04-24  2:07                                       ` Tetsuo Handa
2009-04-24  4:35                                         ` David Miller
2009-04-24  4:41                                           ` David Miller
2009-04-24  4:55                                           ` Tetsuo Handa
2009-04-24  5:26                                           ` Tetsuo Handa
2009-04-24 11:40                                             ` David Miller
2009-04-24 13:57                                               ` [PATCH] LSM: Add security_socket_post_accept() andsecurity_socket_post_recv_datagram() Tetsuo Handa
2009-04-19  8:03 ` [PATCH v2] LSM: Add security_socket_post_accept() and security_socket_post_recv_datagram() Tetsuo Handa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090422065443.GC4221@bx9.net \
    --to=greg@blekko.com \
    --cc=davem@davemloft.net \
    --cc=linux-security-module@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=paul.moore@hp.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.