From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Cc: marcin.slusarz@gmail.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: add roundup_to_blocksize and bytes_to_blocks helper functions
Date: Wed, 22 Apr 2009 14:52:55 -0700 [thread overview]
Message-ID: <20090422145255.1e85253e.akpm@linux-foundation.org> (raw)
In-Reply-To: <1240436400.7356.39.camel@norville.austin.ibm.com>
On Wed, 22 Apr 2009 16:40:00 -0500
Dave Kleikamp <shaggy@linux.vnet.ibm.com> wrote:
> On Wed, 2009-04-22 at 14:10 -0700, Andrew Morton wrote:
>
> > roundup_to_blocksize() isn't a terribly good name, IMO. The name
> > conveys no sense of what the function returns. It _sounds_ like it
> > returns a "block size". But it doesn't - it returns a loff_t.
> > round_up_file_offset_to_block_size() is a bit long though :(
>
> Is round_up_to_block() any better? I don't think the trailing "size"
> helps.
dunno.
If the function is documented and if its arg is a loff_t rather than a
bare ull then I guess that makes things sufficiently clear that we
don't have to fuss about its name too much.
next prev parent reply other threads:[~2009-04-22 21:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-19 18:42 [PATCH] fs: add roundup_to_blocksize and bytes_to_blocks helper functions Marcin Slusarz
2009-04-19 18:51 ` [PATCH] filesystems: start using roundup_to_blocksize and bytes_to_blocks Marcin Slusarz
2009-04-20 19:07 ` Dave Kleikamp
2009-04-20 20:22 ` Dave Kleikamp
2009-04-22 21:10 ` [PATCH] fs: add roundup_to_blocksize and bytes_to_blocks helper functions Andrew Morton
2009-04-22 21:40 ` Dave Kleikamp
2009-04-22 21:52 ` Andrew Morton [this message]
2009-04-26 17:21 ` Marcin Slusarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090422145255.1e85253e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=shaggy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.