From: Jesse Barnes <jesse.barnes@intel.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] x86/pci: do assign root bus res if _CRS is used
Date: Wed, 22 Apr 2009 15:08:52 -0700 [thread overview]
Message-ID: <20090422150852.3ea4989b@hobbes> (raw)
In-Reply-To: <49ED22EC.2040204@kernel.org>
On Mon, 20 Apr 2009 18:35:40 -0700
Yinghai Lu <yinghai@kernel.org> wrote:
>
> it wil be overwriten later if _CRS is used, so don't bother to set it.
>
> [ Impact: cleanup ]
Applied, thanks.
A general comment on your patches though: please spent a few more
minutes coming up with readable & useful summaries & changelogs. Most
of the time when applying your patches (which are generally fine
technically) I have to delete the whole changelog and come up with a
new one based on reading the sources and then your patch. It would be
nice if I didn't have to. Grammar and spelling mistakes are fine (I
usually catch those) but when the logic of the changelog is all wrong,
or it doesn't describe what it's doing and why, it makes things much
more difficult.
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2009-04-22 22:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-21 1:35 [PATCH] x86/pci: do assign root bus res if _CRS is used Yinghai Lu
2009-04-22 22:08 ` Jesse Barnes [this message]
2009-04-27 19:44 ` Bjorn Helgaas
2009-04-27 19:53 ` Jesse Barnes
2009-04-27 20:15 ` Yinghai Lu
2009-04-27 20:39 ` Bjorn Helgaas
2009-04-27 21:00 ` Yinghai Lu
2009-04-27 22:24 ` Bjorn Helgaas
2009-04-28 2:07 ` Yinghai Lu
2009-04-29 23:08 ` Bjorn Helgaas
2009-04-30 15:14 ` Bjorn Helgaas
2009-04-30 15:14 ` Bjorn Helgaas
2009-05-08 22:40 ` Bjorn Helgaas
2009-05-08 22:40 ` Bjorn Helgaas
2009-05-20 23:49 ` Jesse Barnes
2009-05-21 0:10 ` Yinghai Lu
2009-05-21 14:46 ` Bjorn Helgaas
2009-05-21 16:37 ` Gary Hade
2009-05-27 19:41 ` Gary Hade
2009-06-11 18:00 ` Jesse Barnes
2009-06-11 18:00 ` Jesse Barnes
2009-06-16 21:54 ` Jesse Barnes
2009-04-30 0:06 ` Gary Hade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090422150852.3ea4989b@hobbes \
--to=jesse.barnes@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.