From: mbroz@sourceware.org <mbroz@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW test/t-partial-activate.sh to ...
Date: 22 Apr 2009 17:00:32 -0000 [thread overview]
Message-ID: <20090422170032.16152.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: mbroz at sourceware.org 2009-04-22 17:00:31
Modified files:
. : WHATS_NEW
test : t-partial-activate.sh
tools : vgreduce.c
Log message:
Fix vgreduce --removemissing failure exit code.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1093&r2=1.1094
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/test/t-partial-activate.sh.diff?cvsroot=lvm2&r1=1.1&r2=1.2
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgreduce.c.diff?cvsroot=lvm2&r1=1.88&r2=1.89
--- LVM2/WHATS_NEW 2009/04/22 09:39:45 1.1093
+++ LVM2/WHATS_NEW 2009/04/22 17:00:28 1.1094
@@ -1,5 +1,6 @@
Version 2.02.46 -
================================
+ Fix vgreduce --removemissing failure exit code.
Fix remote metadata backup for clvmd.
Alloc PV internal structure from VG mempool if possible.
Fix metadata backup to run after vg_commit always.
--- LVM2/test/t-partial-activate.sh 2008/09/29 16:04:57 1.1
+++ LVM2/test/t-partial-activate.sh 2009/04/22 17:00:30 1.2
@@ -6,7 +6,6 @@
lvchange -a n $vg/mirror
disable_dev $dev1
-# FIXME should this return an error code due to that big fat WARNING?
-vgreduce --removemissing $vg
+not vgreduce --removemissing $vg
not lvchange -v -a y $vg/mirror
lvchange -v --partial -a y $vg/mirror
--- LVM2/tools/vgreduce.c 2009/04/10 10:01:39 1.88
+++ LVM2/tools/vgreduce.c 2009/04/22 17:00:31 1.89
@@ -556,11 +556,13 @@
}
backup(vg);
- if (fixed)
+ if (fixed) {
log_print("Wrote out consistent volume group %s",
vg_name);
+ ret = ECMD_PROCESSED;
+ } else
+ ret = ECMD_FAILED;
- ret = ECMD_PROCESSED;
} else {
if (!vg_check_status(vg, EXPORTED_VG | LVM_WRITE | RESIZEABLE_VG))
goto out;
reply other threads:[~2009-04-22 17:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090422170032.16152.qmail@sourceware.org \
--to=mbroz@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.