All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Krill <ben@codiert.org>
To: Ricardo Ribalda Delgado <ricardo.ribalda@uam.es>
Cc: David.Woodhouse@intel.com, linuxppc-dev@ozlabs.org
Subject: Re: ofpart:  Partitions at same address cannot have the same name
Date: Wed, 22 Apr 2009 19:10:30 +0200	[thread overview]
Message-ID: <20090422171030.GH14906@codiert.org> (raw)
In-Reply-To: <1240415535-10939-1-git-send-email-ricardo.ribalda@uam.es>

>--- a/drivers/mtd/ofpart.c
>+++ b/drivers/mtd/ofpart.c
>@@ -48,7 +48,7 @@ int __devinit of_mtd_parse_partitions(struct device *dev,
> 
> 		/* check if this is a partition node */
> 		partname = of_get_property(pp, "name", &len);
>-		if (strcmp(partname, "partition") != 0) {
>+		if (strncmp(partname, "partition", strlen("partition") != 0) {

Hi Recardo,

I would suggest to do:

		if (strcmp(partname, "partition") <= 0) {

cheers
 ben

  reply	other threads:[~2009-04-22 17:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-22  8:05 [MTD] ofpart: Partitions at same address cannot have the same name Ricardo Ribalda Delgado
2009-04-22  9:24 ` Peter Korsgaard
2009-04-22 15:34   ` Ricardo Ribalda Delgado
2009-04-22 15:52   ` Ricardo Ribalda Delgado
2009-04-22 17:10     ` Benjamin Krill [this message]
2009-04-22 17:27       ` Scott Wood
2009-04-22 17:56         ` Ricardo Ribalda Delgado
2009-04-22 18:11           ` Scott Wood
2009-04-22 18:58             ` Ricardo Ribalda Delgado
2009-04-22 17:59       ` Ricardo Ribalda Delgado
2009-04-22 18:33         ` Benjamin Krill
2009-04-30  3:19 ` [MTD] " Benjamin Herrenschmidt
2009-04-30  5:32   ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090422171030.GH14906@codiert.org \
    --to=ben@codiert.org \
    --cc=David.Woodhouse@intel.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=ricardo.ribalda@uam.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.