From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [RFC PATCH 4/5] ASoC: remove those unnecessary #ifdef CONFIG_PXA3xx .. #endif Date: Thu, 23 Apr 2009 09:17:15 +0100 Message-ID: <20090423081715.GA30105@sirena.org.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cassiel.sirena.org.uk (cassiel.sirena.org.uk [80.68.93.111]) by alsa0.perex.cz (Postfix) with ESMTP id BF85F103838 for ; Thu, 23 Apr 2009 10:17:16 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Eric Miao Cc: alsa-devel@alsa-project.org, Paul Shen , linux-arm-kernel , Philipp Zabel List-Id: alsa-devel@alsa-project.org On Thu, Apr 23, 2009 at 01:06:55PM +0800, Eric Miao wrote: > These are unnecessary since the compiler is smart enough to optimize > the code away if CONFIG_PXA3xx is not defined, when cpu_is_pxa3xx() > will just be expanded to constant 0. This isn't done for compiler optimisation - it's done because the register bit macros are only defined if PXA3xx support is being built in. I've no problem with removing those guards but without that you'll get build failures on PXA2xx.