Re: patch for virtual machine oriented scheduling(3)

[Gleb Natapov <gleb@redhat.com>]

On Thu, Apr 23, 2009 at 07:34:46PM +0800, alex wrote:
> On Thu, Apr 23, 2009 at 2:15 PM, Gleb Natapov <gleb@redhat.com> wrote:
> > On Wed, Apr 22, 2009 at 10:55:24PM +0800, alex wrote:
> >> the code for credit scheduler
> >> -----------------------------------------------------------------------------------------------------------------------
> >> diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
> >> index 4d76bb6..9e88ff0 100644
> >> --- a/arch/x86/kvm/lapic.c
> >> +++ b/arch/x86/kvm/lapic.c
> >> @@ -284,7 +284,7 @@ int kvm_apic_match_dest(struct kvm_vcpu *vcpu,
> >> struct kvm_lapic *source,
> >>                   "dest_mode 0x%x, short_hand 0x%x\n",
> >>                   target, source, dest, dest_mode, short_hand);
> >>
> >> -       ASSERT(!target);
> >> +       ASSERT(target);
> > Did you mean it?
> 
> Yes.
Then send it as separate patch please.

> if target is not NULL, !target is 0, thus ASSERT(!target) will fail.
> 
> from the context(and from the runtime output), it is easy to see that
> target should not be NULL.
> 
> previously, this did not cause any problem is that DEBUG is not defined.
> If you define DEBUG the head of file lapic.c, and run KVM, you will
> find this bug.

--
			Gleb.