From: Andrew Morton <akpm@linux-foundation.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: hartleys@visionengravers.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/vmalloc.c: fix sparse warning
Date: Thu, 23 Apr 2009 13:51:46 -0700 [thread overview]
Message-ID: <20090423135146.89026a2b.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090423203557.GY8633@ZenIV.linux.org.uk>
On Thu, 23 Apr 2009 21:35:57 +0100
Al Viro <viro@ZenIV.linux.org.uk> wrote:
> On Thu, Apr 23, 2009 at 01:23:58PM -0700, Andrew Morton wrote:
> > On Fri, 17 Apr 2009 20:55:06 -0400
> > "H Hartley Sweeten" <hartleys@visionengravers.com> wrote:
> >
> > > Fix sparse warning in mm/vmalloc.c.
> > >
> > > warning: symbol 'tmp' shadows an earlier one
>
> Folks, could we please add to appropriate documentation (SubmittingPatches,
> perhaps) a bit about using descriptive subjects?
If everyone did that, my typing skillz would deteriorate.
> In general, "$TOOL warning in $FILE" says nothing useful. In this case
> "Get rid of shadowed variable in mm/vmalloc.c:<function>" would be far
> more useful, with "found by sparse" _maybe_ showing up in the commit
> message more or less as a footnote. Or even "shadowed variable in
> mm/vmalloc.c:<function>".
yup.
prev parent reply other threads:[~2009-04-23 20:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-18 0:55 [PATCH] mm/vmalloc.c: fix sparse warning H Hartley Sweeten
2009-04-23 20:23 ` Andrew Morton
2009-04-23 20:35 ` Al Viro
2009-04-23 20:51 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090423135146.89026a2b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.