From: Olof Johansson <olof@lixom.net>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] pasemi_mac: mac_to_intf() error not noticed
Date: Thu, 23 Apr 2009 12:56:48 -0500 [thread overview]
Message-ID: <20090423175648.GA4406@lixom.net> (raw)
In-Reply-To: <49F0A8E9.2010702@gmail.com>
On Thu, Apr 23, 2009 at 07:44:09PM +0200, Roel Kluin wrote:
> mac_to_intf() can return -1 when no device or function was found, but when
> mac->dma_if is unsigned. The error wasn't noticed.
This can in practice never happen which is likely why it went
unnoticed.
I object to the usage of err in the way you use it, it's completely
counterintuitive to name a variable that will hold valid data to 'err'.
So, define a new variable with an appropriate name, please.
-Olof
next prev parent reply other threads:[~2009-04-23 17:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 17:44 [PATCH] pasemi_mac: mac_to_intf() error not noticed Roel Kluin
2009-04-23 17:56 ` Olof Johansson [this message]
2009-04-23 18:53 ` Roel Kluin
2009-04-23 19:54 ` Olof Johansson
2009-04-27 10:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090423175648.GA4406@lixom.net \
--to=olof@lixom.net \
--cc=akpm@linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.