From: Joerg Roedel <joerg.roedel@amd.com>
To: David Vrabel <david.vrabel@csr.com>
Cc: Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: dma_debug_device_change() gives bogus errors
Date: Fri, 24 Apr 2009 14:18:40 +0200 [thread overview]
Message-ID: <20090424121840.GO17438@amd.com> (raw)
In-Reply-To: <49F1A064.6040100@csr.com>
On Fri, Apr 24, 2009 at 12:20:04PM +0100, David Vrabel wrote:
> dma_debug_device_change() gives bogus errors if a driver unmaps dma
> buffers within its driver->remove() method. This is because the
> BUS_NOTIFY_UNBIND_DRIVER notification is raised before calling
> driver->remove() (see __device_release_driver() in drivers/base/dd.c).
>
> By the time my driver->remove() completes, there are no DMA mappings
> (debug_dma_dump_mappings() produces no output).
>
> Also, somewhat surprisingly, it only prints the error the first time the
> driver is unbound.
Thanks for the report. This is being worked on already. I will disable
this check for 2.6.30 and try to get a solution upstream for 2.6.31.
Joerg
--
| Advanced Micro Devices GmbH
Operating | Karl-Hammerschmidt-Str. 34, 85609 Dornach bei München
System |
Research | Geschäftsführer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni
Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
| Registergericht München, HRB Nr. 43632
prev parent reply other threads:[~2009-04-24 12:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-24 11:20 dma_debug_device_change() gives bogus errors David Vrabel
2009-04-24 12:18 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090424121840.GO17438@amd.com \
--to=joerg.roedel@amd.com \
--cc=david.vrabel@csr.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.