From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.171]) by ozlabs.org (Postfix) with ESMTP id 97504DDF07 for ; Fri, 24 Apr 2009 20:50:15 +1000 (EST) From: Arnd Bergmann To: linuxppc-dev@ozlabs.org Subject: Re: [microblaze-uclinux] [PATCH 11/11] microblaze: Kconfig: Enable drivers for Microblaze Date: Fri, 24 Apr 2009 12:49:48 +0200 References: <764365e7af2e476e43cd674738e51f13b306979b.1239874968.git.monstr@monstr.eu> <1d3f23370904201924n4ab592cdq49a4a4c8ec78d1df@mail.gmail.com> In-Reply-To: <1d3f23370904201924n4ab592cdq49a4a4c8ec78d1df@mail.gmail.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="Boundary-00=_NlZ8Jr6788VPglS" Message-Id: <200904241249.49870.arnd@arndb.de> Cc: Stephen Neuendorffer , linux-kernel@vger.kernel.org, microblaze-uclinux@itee.uq.edu.au, John Linn , John Williams List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --Boundary-00=_NlZ8Jr6788VPglS Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tuesday 21 April 2009, John Williams wrote: > Some (most?) of the Xilinx drivers currently have this construct: > > #ifdef CONFIG_OF > > // probe using OF > > #else If there are multiple ways of detecting the device, then the driver should be compilable on any system that allows either one. At the very least, it should be restricted to CONFIG_HAS_IOMEM, which is probably required for any of these, but not provided on stuff like UML or s390. Drivers that use of_* functions unconditionally need to depend on CONFIG_OF. Also, some of the xilinx drivers apparantly use DCR, which in turn is only defined when you have CONFIG_PPC_DCR, and these have so far only been used on powerpc. If other architectures start using DCR (I hope that never happens), we will need a global CONFIG_DCR option. Arnd <>< --Boundary-00=_NlZ8Jr6788VPglS Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: 7bit

On Tuesday 21 April 2009, John Williams wrote:

> Some (most?) of the Xilinx drivers currently have this construct:

>

> #ifdef CONFIG_OF

>

> // probe using OF

>

> #else

If there are multiple ways of detecting the device, then

the driver should be compilable on any system that allows

either one.

At the very least, it should be restricted to CONFIG_HAS_IOMEM,

which is probably required for any of these, but not provided

on stuff like UML or s390.

Drivers that use of_* functions unconditionally need to

depend on CONFIG_OF.

Also, some of the xilinx drivers apparantly use DCR, which in turn is

only defined when you have CONFIG_PPC_DCR, and these

have so far only been used on powerpc. If other architectures

start using DCR (I hope that never happens), we will need a

global CONFIG_DCR option.

Arnd <><

--Boundary-00=_NlZ8Jr6788VPglS--