Re: [Qemu-devel] [7234] Use a more natural order

[Nathan Froyd <froydnj@codesourcery.com>]

On Fri, Apr 24, 2009 at 02:07:06PM -0400, Lennart Sorensen wrote:
> On Thu, Apr 23, 2009 at 11:46:25PM +0100, Jamie Lokier wrote:
> > Sure, it was ok practice back in the days when compilers would let you
> > write "if (x = 0)", but those days are long gone.  Now all compilers
> > warn, and you can ask them to make it an error.  A compiler check is
> > much safer than depending on writing style, especially a weird one
> > that's inconsistent with other writing in the same code, and
> > inconsistent with English thinking.
> 
> I highly doubt all compilers warn.  Current gcc versions do, but not
> everyone uses current gcc.

Documentation indicates that the relevant warning (-Wparatheses) has
been supported since at least 2.95.3 (released early 2001); I imagine it
has been supported since the corresponding major release of 2.95.0
(released mid-1999).

-Nathan