From: Theodore Tso <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Christian Kujau <lists@nerdbynature.de>, linux-ext4@vger.kernel.org
Subject: Re: ext4_ext_check_inode: bad header/extent in inode
Date: Fri, 24 Apr 2009 16:59:27 -0400 [thread overview]
Message-ID: <20090424205927.GA13608@mit.edu> (raw)
In-Reply-To: <49F22244.5040407@redhat.com>
On Fri, Apr 24, 2009 at 03:34:12PM -0500, Eric Sandeen wrote:
> So these are funny inodes:
>
> # file mnt/lost+found/*
> mnt/lost+found/#12042: setuid setgid character special
> mnt/lost+found/#12207: setgid socket
> mnt/lost+found/#12249: setgid socket
>
> by virtue of the corruption.
.
> so we shouldn't be checking the extent header, I think.
>
> if (ei->i_flags & EXT4_EXTENTS_FL) {
> /* Validate extent which is part of inode */
> ret = ext4_ext_check_inode(inode);
> } else if ...
>
> Or maybe fsck should be clearing the extents flag on inodes like this?
>
Good catch! Yeah, probably both. The kernel should only validating
the extent header if the file is regular file, a directory, or a symlink.
And e2fsck should be clearing the extents flag on inodes like this.
I'll create the patch....
- Ted
next prev parent reply other threads:[~2009-04-24 20:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 12:15 ext4_ext_check_inode: bad header/extent in inode Christian Kujau
2009-04-23 12:50 ` Eric Sandeen
2009-04-23 19:04 ` Christian Kujau
2009-04-23 20:40 ` Theodore Tso
2009-04-23 22:15 ` Christian Kujau
2009-04-24 3:20 ` Theodore Tso
2009-04-24 7:09 ` Andreas Dilger
2009-04-24 11:58 ` Theodore Tso
2009-04-24 20:09 ` Andreas Dilger
2009-04-24 8:57 ` Christian Kujau
2009-04-24 9:40 ` Christian Kujau
2009-04-24 12:00 ` Theodore Tso
2009-04-24 12:36 ` Eric Sandeen
2009-04-24 12:42 ` Eric Sandeen
2009-04-24 20:21 ` Christian Kujau
2009-04-24 20:34 ` Eric Sandeen
2009-04-24 20:59 ` Theodore Tso [this message]
2009-04-24 22:54 ` [PATCH] ext4: Do not try to validate extents on special files Theodore Ts'o
2009-04-24 21:02 ` ext4_ext_check_inode: bad header/extent in inode Christian Kujau
2009-04-24 21:23 ` Eric Sandeen
2009-04-24 20:41 ` Christian Kujau
2009-04-23 20:51 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090424205927.GA13608@mit.edu \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=lists@nerdbynature.de \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.