From: Anton Blanchard <anton@samba.org>
To: netdev@vger.kernel.org
Subject: [PATCH] Limit size of route cache hash table
Date: Mon, 27 Apr 2009 13:04:33 +1000 [thread overview]
Message-ID: <20090427030433.GA17454@kryten> (raw)
Right now we have no upper limit on the size of the route cache hash table.
On a 128GB POWER6 box it ends up as 32MB:
IP route cache hash table entries: 4194304 (order: 9, 33554432 bytes)
It would be nice to cap this just for memory consumption reasons, but this
massive hashtable also causes a significant spike when measuring OS
jitter.
With a 32MB hashtable and 4 million entries, rt_worker_func is taking
5 ms to complete. On another system with more memory it's taking 14 ms.
Even though rt_worker_func does call cond_sched() to limit its impact,
in an HPC environment we want to keep all sources of OS jitter to a minimum.
With the patch applied we limit the number of entries to 64k which
can still be overriden by using the rt_entries boot option:
IP route cache hash table entries: 65536 (order: 3, 524288 bytes)
With this patch rt_worker_func takes 0.060 ms on the same system.
Signed-off-by: Anton Blanchard <anton@samba.org>
---
Is 64k a reasonable default for the limit?
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index c40debe..5064c26 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -3397,7 +3397,7 @@ int __init ip_rt_init(void)
0,
&rt_hash_log,
&rt_hash_mask,
- 0);
+ rhash_entries ? 0 : 64 * 1024);
memset(rt_hash_table, 0, (rt_hash_mask + 1) * sizeof(struct rt_hash_bucket));
rt_hash_lock_init();
next reply other threads:[~2009-04-27 3:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-27 3:04 Anton Blanchard [this message]
2009-04-27 5:17 ` [PATCH] Limit size of route cache hash table Eric Dumazet
2009-04-27 5:47 ` Anton Blanchard
2009-04-27 6:12 ` Eric Dumazet
2009-04-27 6:36 ` David Miller
2009-04-27 6:47 ` Eric Dumazet
2009-04-27 11:44 ` Anton Blanchard
2009-04-27 11:50 ` Anton Blanchard
2009-04-27 12:40 ` David Miller
2009-04-27 6:35 ` David Miller
2009-04-27 6:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090427030433.GA17454@kryten \
--to=anton@samba.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.