From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] SH-5: struct pt_regs:syscall_nr is unsigned.
Date: Mon, 27 Apr 2009 08:05:23 +0000 [thread overview]
Message-ID: <20090427080522.GB26020@linux-sh.org> (raw)
In-Reply-To: <49F0C5BF.4090207@gmail.com>
On Thu, Apr 23, 2009 at 09:47:11PM +0200, Roel Kluin wrote:
> vi arch/sh/include/asm/ptrace.h +9
> And note that struct pt_regs:syscall_nr is unsigned.
>
> So I think something like the patch below is required, isn't it? As an
> alternative to the patch below, syscall_nr could become signed. what is
> preferred?
> --------------------------->8-------------8<------------------------------
> In restore_sigcontext() syscall_nr is set to -1, but it is unsigned for
> SH-5.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
syscall_nr should be signed, yes (the assembly code expects that as
well). I've switched it over now, good spotting!
prev parent reply other threads:[~2009-04-27 8:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 19:47 [PATCH] SH-5: struct pt_regs:syscall_nr is unsigned Roel Kluin
2009-04-27 8:05 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090427080522.GB26020@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.