From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gregory Haskins <ghaskins@novell.com>
Cc: kvm@vger.kernel.org, avi@redhat.com
Subject: Re: [PATCH v2] qemu-kvm: add irqfd support
Date: Mon, 27 Apr 2009 13:47:43 +0300 [thread overview]
Message-ID: <20090427104743.GA31112@redhat.com> (raw)
In-Reply-To: <20090424042756.1896.90317.stgit@dev.haskins.net>
On Fri, Apr 24, 2009 at 12:30:17AM -0400, Gregory Haskins wrote:
> +int kvm_irqfd(kvm_context_t kvm, int gsi)
> +{
> + int fd, r;
> +
> + if (!kvm_check_extension(kvm, KVM_CAP_IRQFD))
> + return -ENOENT;
> +
> + fd = eventfd(0, 0);
> + if (fd < 0)
> + return fd;
> +
> + r = assign_irqfd(kvm, fd, gsi);
> + if (r < 0)
> + return r;
Do we need to close fd on error?
> +
> + return fd;
> +}
next prev parent reply other threads:[~2009-04-27 10:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-24 4:30 [PATCH v2] qemu-kvm: add irqfd support Gregory Haskins
2009-04-27 10:47 ` Michael S. Tsirkin [this message]
2009-04-27 11:00 ` Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090427104743.GA31112@redhat.com \
--to=mst@redhat.com \
--cc=avi@redhat.com \
--cc=ghaskins@novell.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.