All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [git patches] Staging: rtxxx0: cleanup and "dumb" merge
Date: Mon, 27 Apr 2009 17:28:32 +0200	[thread overview]
Message-ID: <200904271728.33140.bzolnier@gmail.com> (raw)
In-Reply-To: <20090426183954.GA18449@kroah.com>

On Sunday 26 April 2009 20:39:54 Greg KH wrote:
> On Sun, Apr 26, 2009 at 05:59:20PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > 
> > Hi,
> > 
> > This patchset cleans up rt{286,287,307}0 drivers (66 KLOC removed) and then
> > "dumb" (i.e. rt3070 shares code with rt2870 by including rt2870's .c files
> > and depends on ifdefs to get the correct end result) merges them (142 KLOC
> > removed).  All in all 208 KLOC are gone and we now use the common code for
> > all three Ralink drivers.
> 
> Wonderful!
> 
> Were you able to test that this still works afterward?

I just used some semi-automatic verification of changes -- I scripted build
process with comparing sizes of resulting .o files so when they were different
I was re-auditing the given patch or (if re-audit didn't catch anything)
comparing corresponding .s files.  This of course doesn't provide us with
a complete proof that changes are correct but increases probability of such
outcome significantly. :)

The real testing with RT2860, RT2870 & RT3070 would be much welcomed...

Thanks,
Bart

  reply	other threads:[~2009-04-27 15:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-26 15:59 [git patches] Staging: rtxxx0: cleanup and "dumb" merge Bartlomiej Zolnierkiewicz
2009-04-26 18:39 ` Greg KH
2009-04-27 15:28   ` Bartlomiej Zolnierkiewicz [this message]
2009-04-27 15:40     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200904271728.33140.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.