All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: oprofile-list@lists.sf.net, robert.richter@amd.com,
	linux-kernel@vger.kernel.org
Subject: [PATCH] [1/3] oprofile: re-add force_arch_perfmon option
Date: Mon, 27 Apr 2009 17:44:11 +0200 (CEST)	[thread overview]
Message-ID: <20090427544.130860995@firstfloor.org> (raw)


This re-adds the force_arch_perfmon option that was in the original
arch perfmon patchkit. Originally this was rejected in favour 
of a generalized perfmon=name option, but it turned out implementing
the later in a reliable way is hard (and it would have been easy
to crash the kernel if a user gets it wrong) 

But now Atom and Core i7 support being readded a user would
need to update their oprofile userland to beyond 0.9.4 to use oprofile again
on Atom or Core i7.

To avoid this problem readd the force_arch_perfmon option.
Signed-off-by: Andi Kleen <ak@linux.intel.com>

---
 Documentation/kernel-parameters.txt |    6 ++++++
 arch/x86/oprofile/nmi_int.c         |    6 ++++++
 2 files changed, 12 insertions(+)

Index: linux-2.6.30-rc3-ak/Documentation/kernel-parameters.txt
===================================================================
--- linux-2.6.30-rc3-ak.orig/Documentation/kernel-parameters.txt	2009-04-25 19:11:59.000000000 +0200
+++ linux-2.6.30-rc3-ak/Documentation/kernel-parameters.txt	2009-04-27 13:20:29.000000000 +0200
@@ -1648,6 +1648,12 @@
 	oprofile.timer=	[HW]
 			Use timer interrupt instead of performance counters
 
+	oprofile.force_arch_perfmon=1	[X86]
+			Force use of architectural perfmon instead of
+			the CPU specific event set.
+			This might be useful if you have older oprofile
+			userland or if you want common events over Intel CPUs.
+
 	osst=		[HW,SCSI] SCSI Tape Driver
 			Format: <buffer_size>,<write_threshold>
 			See also Documentation/scsi/st.txt.
Index: linux-2.6.30-rc3-ak/arch/x86/oprofile/nmi_int.c
===================================================================
--- linux-2.6.30-rc3-ak.orig/arch/x86/oprofile/nmi_int.c	2009-02-15 12:09:09.000000000 +0100
+++ linux-2.6.30-rc3-ak/arch/x86/oprofile/nmi_int.c	2009-04-27 13:20:29.000000000 +0200
@@ -389,10 +389,16 @@
 	return 0;
 }
 
+int force_arch_perfmon;
+module_param(force_arch_perfmon, int, 0);
+
 static int __init ppro_init(char **cpu_type)
 {
 	__u8 cpu_model = boot_cpu_data.x86_model;
 
+	if (force_arch_perfmon && cpu_has_arch_perfmon)
+		return 0;
+
 	switch (cpu_model) {
 	case 0 ... 2:
 		*cpu_type = "i386/ppro";

             reply	other threads:[~2009-04-27 15:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-27 15:44 Andi Kleen [this message]
2009-04-27 15:44 ` [PATCH] [2/3] oprofile: remove undocumented oprofile.p4force option Andi Kleen
2009-04-27 15:44 ` [PATCH] [3/3] oprofile: add support for Core i7 and Atom Andi Kleen
2009-05-06 12:50 ` [PATCH] [1/3] oprofile: re-add force_arch_perfmon option Robert Richter
2009-05-06 14:48   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090427544.130860995@firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oprofile-list@lists.sf.net \
    --cc=robert.richter@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.