All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Prendel <andre_prendel@gmx.de>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] Please,
Date: Tue, 28 Apr 2009 11:57:29 +0000	[thread overview]
Message-ID: <20090428115729.GB4717@ubuntu> (raw)
In-Reply-To: <fe6167c00904270421g19534018n7d544427e675d412@mail.gmail.com>

On Mon, Apr 27, 2009 at 01:21:58PM +0200, Didier Roche wrote:
> Hi lm-sensors developer,
> 
> It would be great if lm-sensors can take into account distribution
> LDFLAGS so that exported variables change linker behavior.
> 
> For instance, ubuntu uses -Wl,-Bsymbolic-functions. Taking this patch
> will enable us to just sync from debian on this package.
> 
> In Ubuntu, we've applied the attached patch to achieve the following:
> 
>   * handle default ubuntu LDFLAGS for linking option (LP: #321632)
>     - Remove the old hack directly pushed in lib/Module.mk (now
>       lib/Module.mk if from pristine source)
>     - add debian/patches/07-use-LDFLAGS.patch to take LDFLAGS into account
> 
> Debian and Ubuntu thought you might be interested to handle this
> directly upstream.
> 
> 
> --- lm-sensors-3-3.0.2.orig/lib/Module.mk      2008-05-18
> 8:07:48.000000000 +0200
> +++ lm-sensors-3-3.0.2/lib/Module.mk   2009-01-26 22:15:02.000000000 +0100
> @@ -60,7 +60,7 @@
> 
>  # How to create the shared library
>  $(MODULE_DIR)/$(LIBSHLIBNAME): $(LIBSHOBJECTS)
> -      $(CC) -shared -Wl,-soname,$(LIBSHSONAME) -o $@ $^ -lc -lm
> +      $(CC) -shared $(LDFLAGS) -Wl,-soname,$(LIBSHSONAME) -o $@ $^ -lc -lm
> 
>  $(MODULE_DIR)/$(LIBSHSONAME): $(MODULE_DIR)/$(LIBSHLIBNAME)
>        $(RM) $@
> 
> 
> Thanks in advance. Please CC me as I'm not subscribed to the mailing list.
> Didier
> 
> Ubuntu bug: https://bugs.edge.launchpad.net/debian/+source/lm-sensors-3/+bug/321632
> Debian bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bugQ3171
> 

Applied, thanks.

Andre

> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2009-04-28 11:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-27 11:21 [lm-sensors] Please, Didier Roche
2009-04-28  9:12 ` Andre Prendel
2009-04-28 10:11 ` Jean Delvare
2009-04-28 11:57 ` Andre Prendel [this message]
2009-04-28 13:00 ` Didier Roche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090428115729.GB4717@ubuntu \
    --to=andre_prendel@gmx.de \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.