Re: [PATCH 4/5] ocfs2: remove ->write_super and stop maintaining ->s_dirt

[Joel Becker <Joel.Becker@oracle.com>]

On Mon, Apr 27, 2009 at 09:46:44AM -0400, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Acked-by: Joel Becker <joel.becker@oracle.com>

> 
> Index: linux-2.6/fs/ocfs2/super.c
> ===================================================================
> --- linux-2.6.orig/fs/ocfs2/super.c	2009-04-26 20:17:12.088104363 +0200
> +++ linux-2.6/fs/ocfs2/super.c	2009-04-26 20:17:22.988951278 +0200
> @@ -126,7 +126,6 @@ static int ocfs2_get_sector(struct super
>  			    struct buffer_head **bh,
>  			    int block,
>  			    int sect_size);
> -static void ocfs2_write_super(struct super_block *sb);
>  static struct inode *ocfs2_alloc_inode(struct super_block *sb);
>  static void ocfs2_destroy_inode(struct inode *inode);
>  static int ocfs2_susp_quotas(struct ocfs2_super *osb, int unsuspend);
> @@ -141,7 +140,6 @@ static const struct super_operations ocf
>  	.clear_inode	= ocfs2_clear_inode,
>  	.delete_inode	= ocfs2_delete_inode,
>  	.sync_fs	= ocfs2_sync_fs,
> -	.write_super	= ocfs2_write_super,
>  	.put_super	= ocfs2_put_super,
>  	.remount_fs	= ocfs2_remount,
>  	.show_options   = ocfs2_show_options,
> @@ -365,24 +363,12 @@ static struct file_operations ocfs2_osb_
>  	.llseek =	generic_file_llseek,
>  };
>  
> -/*
> - * write_super and sync_fs ripped right out of ext3.
> - */
> -static void ocfs2_write_super(struct super_block *sb)
> -{
> -	if (mutex_trylock(&sb->s_lock) != 0)
> -		BUG();
> -	sb->s_dirt = 0;
> -}
> -
>  static int ocfs2_sync_fs(struct super_block *sb, int wait)
>  {
>  	int status;
>  	tid_t target;
>  	struct ocfs2_super *osb = OCFS2_SB(sb);
>  
> -	sb->s_dirt = 0;
> -
>  	if (ocfs2_is_hard_readonly(osb))
>  		return -EROFS;
>  
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 

"The cynics are right nine times out of ten."  
        - H. L. Mencken

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127