From: Jarod Wilson <jarod@redhat.com>
To: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
Neil Horman <nhorman@tuxdriver.com>
Subject: [PATCH] crypto: print self-test pass notices in fips mode
Date: Tue, 28 Apr 2009 21:21:35 -0400 [thread overview]
Message-ID: <200904282121.35300.jarod@redhat.com> (raw)
According to our FIPS CAVS testing lab guru, when we're in fips mode,
we *must* print out notices of successful self-test completion for
every alg to be compliant.
Dependent on patch 'crypto: catch base cipher self-test failures in
fips mode', which adds the test_done label.
Signed-off-by: Jarod Wilson <jarod@redhat.com>
---
crypto/testmgr.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index 39ffa69..d0cc85c 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -2149,6 +2149,10 @@ notest:
test_done:
if (fips_enabled && rc)
panic("%s: %s alg self test failed in fips mode!\n", driver, alg);
+ /* fips mode requires we print out self-test success notices */
+ if (fips_enabled && !rc && strncmp(alg, "ctr(aes", 7))
+ printk(KERN_INFO "alg: self-tests for %s (%s) passed\n",
+ driver, alg);
return rc;
}
EXPORT_SYMBOL_GPL(alg_test);
--
Jarod Wilson
jarod@redhat.com
next reply other threads:[~2009-04-29 1:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 1:21 Jarod Wilson [this message]
2009-04-29 10:52 ` [PATCH] crypto: print self-test pass notices in fips mode Neil Horman
2009-04-29 13:18 ` Herbert Xu
2009-04-29 13:21 ` Jarod Wilson
2009-04-29 13:24 ` Jarod Wilson
2009-04-30 21:25 ` [PATCH v2] " Jarod Wilson
2009-05-04 11:51 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904282121.35300.jarod@redhat.com \
--to=jarod@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.