From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [PATCH] scsi: ses check name in enclosure_component_register Date: Tue, 28 Apr 2009 20:03:31 -0600 Message-ID: <20090429020331.GF21648@parisc-linux.org> References: <49F6678D.3080207@kernel.org> <1240957589.3380.67.camel@mulgrave.int.hansenpartnership.com> <49F7979A.8040302@kernel.org> <1240964289.3380.73.camel@mulgrave.int.hansenpartnership.com> <49F7A71F.5040709@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from palinux.external.hp.com ([192.25.206.14]:55400 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759379AbZD2CDd (ORCPT ); Tue, 28 Apr 2009 22:03:33 -0400 Content-Disposition: inline In-Reply-To: <49F7A71F.5040709@kernel.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Yinghai Lu Cc: James Bottomley , Andrew Morton , Kay Sievers , Greg KH , "linux-kernel@vger.kernel.org" , Linux-Scsi On Tue, Apr 28, 2009 at 06:02:23PM -0700, Yinghai Lu wrote: > dev_set_name(cdev, name); > > the name become fmt. Yes, and what happens if 'name' is '%s'? That's James's point. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."