Re: [patch] mm: close page_mkwrite races (try 3)

[Nick Piggin <npiggin@suse.de>]

On Wed, Apr 29, 2009 at 12:24:18AM -0700, Andrew Morton wrote:
> On Wed, 29 Apr 2009 09:12:33 +0200 Nick Piggin <npiggin@suse.de> wrote:
> 
> > I haven't got any prepared, but they should be a pretty trivial
> > backport, provided we also backport c2ec175c39f62949438354f603f4aa170846aabb
> > (which is probably a good idea anyway).
> > 
> > However I will probably wait for a bit, given that the patch isn't upstream
> > yet.
> 
> err, I'd marked it as for-2.6.31.  It looks like that was wrong?

At the time I agreed because I didn't know the severity of the NFS
bugs. So it is up to you and Trond / nfs guys I guess.


> all this:
> 
> #mm-close-page_mkwrite-races-try-3.patch: akpm issues!
> #mm-close-page_mkwrite-races-try-3.patch: check akpm hack
> mm-close-page_mkwrite-races-try-3.patch
> mm-close-page_mkwrite-races-try-3-update.patch
> mm-close-page_mkwrite-races-try-3-fix.patch
> mm-close-page_mkwrite-races-try-3-fix-fix.patch
> 
> is a bit of a worry.  But I guess we won't know until we merge it.

I have nothing against merging it now if you think it is needed.
It's only adding synchronisation, so I doubt it will cause a problem
that pushes the release out.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>