All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: David Howells <dhowells@redhat.com>
Cc: linux-security-module@vger.kernel.org, jmorris@namei.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SELinux: Remove excessive interrupt disablement
Date: Wed, 29 Apr 2009 15:05:22 +0200	[thread overview]
Message-ID: <20090429130522.GA29151@redhat.com> (raw)
In-Reply-To: <20090429124719.19278.51952.stgit@warthog.procyon.org.uk>

On 04/29, David Howells wrote:
>
> @@ -2410,9 +2409,9 @@ static void selinux_bprm_committed_creds(struct linux_binprm *bprm)
>  	 * wait permission to the new task SID. */
>  	read_lock_irq(&tasklist_lock);

_irq is not needed, just read_lock(&tasklist_lock) should be fine.

>  	psig = current->parent->sighand;
> -	spin_lock_irqsave(&psig->siglock, flags);
> +	spin_lock(&psig->siglock);

I think we don't need ->siglock at all.

>  	wake_up_interruptible(&current->parent->signal->wait_chldexit);

off-topic wrt this patch, but I believe we need

	__wake_up_parent(curremt, current->real_parent);

Oleg.


      reply	other threads:[~2009-04-29 13:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-29 12:47 [PATCH] SELinux: Remove excessive interrupt disablement David Howells
2009-04-29 13:05 ` Oleg Nesterov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090429130522.GA29151@redhat.com \
    --to=oleg@redhat.com \
    --cc=dhowells@redhat.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.