From: Jakub Narebski <jnareb@gmail.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Michael J Gruber <git@drmicha.warpmail.net>,
git@vger.kernel.org,
"John 'Warthog9' Hawley" <warthog9@eaglescrag.net>
Subject: Re: [PATCH] gitweb: escape searchtext and parameters for replay
Date: Wed, 29 Apr 2009 15:14:10 +0200 [thread overview]
Message-ID: <200904291514.11331.jnareb@gmail.com> (raw)
In-Reply-To: <0626233F-50D5-4F7E-9009-506FEA77571D@aepfle.de>
On Wed, 29 Apr 2009, Olaf Hering wrote:
> Am 29.04.2009 um 14:28 schrieb Jakub Narebski:
>> On Wed, 29 April 2009, Michael J Gruber wrote:
>
>>>> It should be s=torvalds%40linux instead of s=torvalds\@linux
>>
>> If you by hand edit URL changing '\@' to simply '@', does changed
>> gitweb URL works correctly?
>
> I tried akpm@osdl.org, and @ and . was escaped with a backslash.
> Removing both, and using the plain mail address worked.
This problem was fixed in 7e431ef (gitweb: Separate search regexp from
search text), but this fix is present in git 1.5.2 and later, and
kernel.org gitweb is a fork (adding caching mechanism) of 1.4.5-rc0,
according to info in git.kernel.org HTML source, and it does not have
this fix.
http://git.kernel.org/?p=git/warthog9/gitweb.git;a=summary
I have CC-ed J.H. on this.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2009-04-29 13:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 9:12 Invalid search parameter in webinterface Olaf Hering
2009-04-29 11:44 ` [PATCH] gitweb: escape searchtext and parameters for replay Michael J Gruber
2009-04-29 12:28 ` Jakub Narebski
2009-04-29 12:52 ` Olaf Hering
2009-04-29 13:14 ` Jakub Narebski [this message]
2009-04-29 19:36 ` Jakub Narebski
2009-04-29 20:07 ` Michael J Gruber
2009-04-29 23:11 ` J.H.
2009-04-30 10:17 ` [PATCH (backport for warthog9/gitweb.git)] gitweb: Separate search regexp from search text Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904291514.11331.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=warthog9@eaglescrag.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.