From: Nicolas Sebrecht <nicolas.s.dev@gmail.com>
To: Bill Pemberton <wfp5p@virginia.edu>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: [PATCH 5/6] Re: Remove mix of high and low-precedence booleans
Date: Wed, 29 Apr 2009 18:54:07 +0200 [thread overview]
Message-ID: <20090429165407.GB12908@vidovic> (raw)
In-Reply-To: <1241010743-7020-6-git-send-email-wfp5p@virginia.edu>
On Wed, Apr 29, 2009 at 09:12:22AM -0400, Bill Pemberton wrote:
> Booleans such as &&, ||, ! have higher precedence than and, or, not.
> They should not be mixed.
But round brackets have higher precedence than both '&&' and 'and',
right? If so, why thoses changes?
> - } elsif (-d $f and !check_file_rev_conflict($f)) {
> + } elsif (-d $f && !check_file_rev_conflict($f)) {
> - } elsif ((-f $f or -p $f) and !check_file_rev_conflict($f)) {
> + } elsif ((-f $f || -p $f) && !check_file_rev_conflict($f)) {
> - if (!defined $valid_re or $resp =~ /$valid_re/) {
> + if (!defined $valid_re || $resp =~ /$valid_re/) {
--
Nicolas Sebrecht
next prev parent reply other threads:[~2009-04-29 16:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 13:12 [PATCH 0/6] cleanups for git-send-email Bill Pemberton
2009-04-29 13:12 ` [PATCH 1/6] Remove return undef from validate_patch Bill Pemberton
2009-04-29 13:12 ` [PATCH 2/6] Remove function prototypes from git-send-email.perl Bill Pemberton
2009-04-29 13:12 ` [PATCH 3/6] Remove return undef from ask() Bill Pemberton
2009-04-29 13:12 ` [PATCH 4/6] Add explict return to end of subroutines Bill Pemberton
2009-04-29 13:12 ` [PATCH 5/6] Remove mix of high and low-precedence booleans Bill Pemberton
2009-04-29 13:12 ` [PATCH 6/6] Remove bareword filehandles in git-send-email.perl Bill Pemberton
2009-05-03 20:58 ` Jeff King
2009-05-03 21:34 ` Francis Galiegue
2009-05-04 6:12 ` H.Merijn Brand
2009-05-04 6:53 ` Francis Galiegue
2009-05-04 7:41 ` H.Merijn Brand
2009-04-29 16:54 ` Nicolas Sebrecht [this message]
2009-04-29 17:00 ` [PATCH 5/6] Re: Remove mix of high and low-precedence booleans Bill Pemberton
2009-05-03 20:31 ` [PATCH 4/6] Add explict return to end of subroutines Jeff King
2009-05-03 20:26 ` [PATCH 3/6] Remove return undef from ask() Jeff King
2009-05-04 2:26 ` Jay Soffian
2009-05-03 20:27 ` [PATCH 2/6] Remove function prototypes from git-send-email.perl Jeff King
2009-05-03 19:46 ` [PATCH 1/6] Remove return undef from validate_patch Jeff King
2009-04-29 19:18 ` [PATCH 0/6] cleanups for git-send-email Junio C Hamano
2009-04-29 19:48 ` Bill Pemberton
2009-04-29 20:23 ` Junio C Hamano
2009-04-29 22:27 ` [PATCH 0/6] " Nicolas Sebrecht
2009-04-30 8:11 ` Andreas Ericsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090429165407.GB12908@vidovic \
--to=nicolas.s.dev@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.