All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: Best practice for loading platform modules
Date: Wed, 29 Apr 2009 18:44:00 +0000	[thread overview]
Message-ID: <20090429184400.GA7527@kroah.com> (raw)
In-Reply-To: <c4aed99f0904291105u1d4c0081qe91969a3ada64c96@mail.gmail.com>

On Wed, Apr 29, 2009 at 02:31:49PM -0400, Chris Hallinan wrote:
> On Wed, Apr 29, 2009 at 2:12 PM, Greg KH <greg@kroah.com> wrote:
> > On Wed, Apr 29, 2009 at 11:11:35AM -0700, Greg KH wrote:
> >> On Wed, Apr 29, 2009 at 02:05:37PM -0400, Chris Hallinan wrote:
> >> > I have an OMAP3 board, and want usb (host mode) configured as a
> >> > loadable module.  Using a generic rule such as this:
> >> > RUN+="/sbin/modprobe -b $env{MODALIAS}"
> >> >
> >> > ends up passing "platform:musb_hdrc" to modprobe, which obviously
> >> > fails.
> >>
> >> Why would that fail?  Do you have the proper modalias in the kernel
> >> module to handle this?  If not, can you add it?
> >
> > I see:
> >        MODULE_ALIAS("platform:" MUSB_DRIVER_NAME);
> > in the musb code, perhaps MUSB_DRIVER_NAME is not set correctly to be
> > "musb_hdrc" somehow?
> 
> >From musb_core.c:
> 
> #define MUSB_DRIVER_NAME "musb_hdrc"
> const char musb_driver_name[] = MUSB_DRIVER_NAME;

Good, so you should be fine.

Can you run:
	modprobe -n -v platform:musb_hdrc
on your system?

It should try to load that module, as it looks like you have it set up
properly, based on the module alias.

> So somewhere else in kernel code (common Kobject/platform code, I
> don't know) must be prepending the string "platform:" to the driver
> name.  Is this what you think the problem is? All of the platform
> drivers display this way.  From a simple script I wrote that dumps
> env:

Yes, that is correct, this is what is supposed to be happening.

thanks,

greg k-h

  parent reply	other threads:[~2009-04-29 18:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-29 18:05 Best practice for loading platform modules Chris Hallinan
2009-04-29 18:11 ` Greg KH
2009-04-29 18:12 ` Greg KH
2009-04-29 18:31 ` Chris Hallinan
2009-04-29 18:44 ` Greg KH [this message]
2009-04-29 19:15 ` Chris Hallinan
2009-04-29 19:25 ` Greg KH
2009-04-29 19:33 ` Kay Sievers
2009-04-29 19:35 ` Chris Hallinan
2009-04-29 19:46 ` Kay Sievers
2009-04-29 19:53 ` Chris Hallinan
2009-04-29 20:18 ` Greg KH
2009-04-30  0:48 ` Chris Hallinan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090429184400.GA7527@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.