From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3][Net][ARM] Switched dm644x_emac Ethernet driver to use newer API
Date: Wed, 29 Apr 2009 22:49:37 +0200 [thread overview]
Message-ID: <20090429204937.GC522@game.jcrosoft.org> (raw)
In-Reply-To: <49F8B8B5.9070703@gmail.com>
On 13:29 Wed 29 Apr , Ben Warren wrote:
> Hi J-C,
>
> Jean-Christophe PLAGNIOL-VILLARD wrote:
> <snip>
>>> +/*
>>> + * * Initializes on-chip ethernet controllers.
>>> + * * to override, implement board_eth_init()
>>> + * */
>>> +int cpu_eth_init(bd_t *bis)
>>> +{
>>> +#if defined(CONFIG_DRIVER_TI_EMAC)
>>> + dm644x_emac_initialize();
>>> +#endif
>>> + return 0;
>>> +}
>>>
>> please move this to the soc
>> arm926ejs/davinci/cpu.c
>>
>> the cpu.c is destinated to be removed in most of the case
>> or at least all the soc specific code
>>
>> Best Regards,
>> J.
>>
> There is currently no such file (not even in arm/next), or that's where
> this would have gone. This function needs to be in a source file that
> already has strongly-linked symbols or it won't override the weak
> version in net/eth.c. I'm certainly open to suggestions.
or simply add an entry in the lds this will force the file to be evaluated
first
Best Regards,
J.
next prev parent reply other threads:[~2009-04-29 20:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 17:12 [U-Boot] [PATCH 0/3][Net][ARM] Davinci Ethernet driver cleanup Ben Warren
2009-04-28 17:12 ` [U-Boot] [PATCH 1/3][Net][ARM] Moved Davinci Ethernet driver to drivers/net Ben Warren
2009-04-28 17:12 ` [U-Boot] [PATCH 2/3][Net][ARM] Initial cleanup of Davinci Ethernet driver Ben Warren
2009-04-28 17:12 ` [U-Boot] [PATCH 3/3][Net][ARM] Switched dm644x_emac Ethernet driver to use newer API Ben Warren
2009-04-29 20:13 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-29 20:29 ` Ben Warren
2009-04-29 20:49 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-04-29 22:11 ` Ben Warren
2009-04-29 23:19 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-30 4:28 ` David Brownell
2009-04-28 19:54 ` [U-Boot] [PATCH 1/3][Net][ARM] Moved Davinci Ethernet driver to drivers/net David Brownell
2009-04-28 20:04 ` Ben Warren
2009-04-29 23:32 ` [U-Boot] [PATCH 0/3][Net][ARM] Davinci Ethernet driver cleanup David Brownell
2009-04-29 23:38 ` Ben Warren
2009-04-30 5:59 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <C9D59C82B94F474B872F2092A87F26148147B6A3@dlee07.ent.ti.com>
2009-05-12 17:43 ` Ben Warren
2009-05-12 18:28 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090429204937.GC522@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.