From: Ivo van Doorn <ivdoorn@gmail.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Alban Browaeys <prahal@yahoo.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
users@rt2x00.serialmonkey.com
Subject: Re: [PATCH 3/5] rt2x00: Fix the interval for rfkill and link_tuner.
Date: Wed, 29 Apr 2009 21:57:22 +0200 [thread overview]
Message-ID: <200904292157.22412.IvDoorn@gmail.com> (raw)
In-Reply-To: <20090429194307.GC3306@tuxdriver.com>
On Wednesday 29 April 2009, John W. Linville wrote:
> On Tue, Apr 28, 2009 at 10:18:02PM +0200, Ivo Van Doorn wrote:
> > On Tue, Apr 28, 2009 at 8:57 PM, John W. Linville
> > <linville@tuxdriver.com> wrote:
> > > On Sun, Apr 26, 2009 at 04:09:11PM +0200, Ivo van Doorn wrote:
> > >> From: Alban Browaeys <prahal@yahoo.com>
> > >>
> > >> extra parenthesis made the value an argument and the value of the
> > >> define empty. This was triggering those very fast.
> > >>
> > >> Signed-off-by: Alban Browaeys <prahal@yahoo.com>
> > >> Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
> > >
> > > ???
> > >
> > > If that were so, wouldn't that have caused compile-time errors?
> >
> > I've CCed Alban so he can explain the issue he experienced..
> >
> > For me this patch is just a style-fix, because those
> > parenthesis were useless anyway.
>
> I'd be happy to take it as a style fix, but it needs an appropriate
> changelog for that.
Ok, please drop this patch. I'll send the version with a better
description in a few moments.
Ivo
next prev parent reply other threads:[~2009-04-29 19:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-26 14:08 [PATCH 1/5] rt2x00: Move iv_len into tx descriptor data Ivo van Doorn
2009-04-26 14:08 ` [PATCH 2/5] rt2x00: Add support for L2 padding during TX/RX Ivo van Doorn
2009-04-26 14:09 ` [PATCH 3/5] rt2x00: Fix the interval for rfkill and link_tuner Ivo van Doorn
2009-04-26 14:09 ` [PATCH 4/5] rt2x00: Implement support for 802.11n Ivo van Doorn
2009-04-26 14:11 ` [PATCH 5/5] rt2x00: Implement support for rt2800usb Ivo van Doorn
2009-04-28 18:57 ` [PATCH 3/5] rt2x00: Fix the interval for rfkill and link_tuner John W. Linville
2009-04-28 20:18 ` Ivo Van Doorn
2009-04-29 19:43 ` John W. Linville
2009-04-29 19:57 ` Ivo van Doorn [this message]
2009-04-29 22:09 ` Alban browaeys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904292157.22412.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=prahal@yahoo.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.