From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763265AbZD2WoF (ORCPT ); Wed, 29 Apr 2009 18:44:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760774AbZD2WWH (ORCPT ); Wed, 29 Apr 2009 18:22:07 -0400 Received: from kroah.org ([198.145.64.141]:40825 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760411AbZD2WV7 (ORCPT ); Wed, 29 Apr 2009 18:21:59 -0400 X-Mailbox-Line: From gregkh@mini.kroah.org Wed Apr 29 15:09:31 2009 Message-Id: <20090429220931.578718104@mini.kroah.org> User-Agent: quilt/0.48-1 Date: Wed, 29 Apr 2009 15:07:57 -0700 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org, paul.moore@hp.com Cc: Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , Domenico Andreoli , Willy Tarreau , Rodrigo Rubira Branco , Jake Edge , Eugene Teo , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, jmorris@namei.org, greg@kroah.com, chrisw@redhat.com, error27@gmail.com, Eugene Teo Subject: [patch 58/58] unreached code in selinux_ip_postroute_iptables_compat() (CVE-2009-1184) References: <20090429220659.339950874@mini.kroah.org> Content-Disposition: inline; filename=unreached-code-in-selinux_ip_postroute_iptables_compat.patch In-Reply-To: <20090429221657.GA11765@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2.6.27-stable review patch. If anyone has any objections, please let us know. ------------------ From: Eugene Teo Not upstream in 2.6.30, as the function was removed there, making this a non-issue. Node and port send checks can skip in the compat_net=1 case. This bug was introduced in commit effad8d. Signed-off-by: Eugene Teo Reported-by: Dan Carpenter Acked-by: James Morris Acked-by: Paul Moore Signed-off-by: Greg Kroah-Hartman --- security/selinux/hooks.c | 1 + 1 file changed, 1 insertion(+) --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -4467,6 +4467,7 @@ static int selinux_ip_postroute_iptables if (err) return err; err = avc_has_perm(sk_sid, if_sid, SECCLASS_NETIF, netif_perm, ad); + if (err) return err; err = sel_netnode_sid(addrp, family, &node_sid);