From: Al Viro <viro@ZenIV.linux.org.uk>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/super.c: fix sparse warning
Date: Thu, 30 Apr 2009 01:42:05 +0100 [thread overview]
Message-ID: <20090430004205.GO8633@ZenIV.linux.org.uk> (raw)
In-Reply-To: <BD79186B4FD85F4B8E60E381CAEE1909016C1B15@mi8nycmail19.Mi8.com>
On Wed, Apr 29, 2009 at 08:14:57PM -0400, H Hartley Sweeten wrote:
> Sparse reports the following in fs/super.c:
>
> warning: Using plain integer as NULL pointer
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Subrata Modak <subrata@linux.vnet.ibm.com>
Applied.
However, I would *really* ask you to avoid that kind of subjects in
the future. Proper subject for that one is "NULL noise in <file>" (or
<file>:<function>. Sparse doesn't even need to be mentioned.
sparse generates many kinds of warnings. And they are neither equal
nor equally interesting.
Kindly use subjects that would tell what's going on; "$TOOL gives
some warning in $FILE" is bloody useless.
prev parent reply other threads:[~2009-04-30 0:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-30 0:14 [PATCH] fs/super.c: fix sparse warning H Hartley Sweeten
2009-04-30 0:42 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090430004205.GO8633@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.